Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm postinstall script #18

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Remove npm postinstall script #18

merged 1 commit into from
Mar 6, 2015

Conversation

ruipenso
Copy link
Member

@ruipenso ruipenso commented Mar 6, 2015

When using npm install angular-oauth2 --save, since bower is a devDependency the postinstall script will fail.

In this PR we're removing the postinstall script and updating the documentation to guide the user on how to install the required dependencies.

Fixes #17.

<script src="bower_components/angular-oauth2/dist/angular-oauth2.min.js"></script>
<script src="<VENDORS_FOLDER>/angular/angular.min.js"></script>
<script src="<VENDORS_FOLDER>/angular-cookie/dist/angular-cookie.min.js"></script>
<script src="<VENDORS_FOLDER>/query-string/query-string.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VENDOR_FOLDER?

@ruipenso ruipenso force-pushed the bugfix/remove-postinstall branch from 51f534f to e751f15 Compare March 6, 2015 11:10
fixe added a commit that referenced this pull request Mar 6, 2015
@fixe fixe merged commit 63da6e3 into master Mar 6, 2015
@fixe fixe deleted the bugfix/remove-postinstall branch March 6, 2015 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM install fails
2 participants