Prevent loading angular multiple times with webpack #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @erhardos. I'll take a look ASAP. |
pgom
reviewed
Jan 10, 2018
| "angular-mocks": "1.5.9", | ||
| "browserify": "^14.5.0", |
There was a problem hiding this comment.
Why did you need to add browserify?
There was a problem hiding this comment.
Found out why you needed to add this dependency.
pgom
reviewed
Jan 10, 2018
| "should": "^4.6.0", | ||
| "sinon": "^1.17.3", | ||
| "watchify": "^3.9.0", |
There was a problem hiding this comment.
Same as browserify dependency
pgom
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies were unlocked and moved to devDependencies, fixes #123
Update browserify fixes #126
Also fixes tests to work with newest Chrome version.