-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to send client credentials (client_id and client_secret) in the header #122
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass the requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just included the dist
files... Where is the actual source code?
And, please remove the dist
files - it will be included on the release.
…ecret) in the header" This reverts commit 1d8f881.
It should be fine now. |
Any news about this pull request? |
I fixed all the JSHint warnings. This pull request is ready for your review. :) |
The RFC 6749 about OAuth 2.0 (https://tools.ietf.org/html/rfc6749#section-2.3.1) mentions the following:
"Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes). The parameters can only
be transmitted in the request-body and MUST NOT be included in the
request URI."
In order to be conform with this RFC, this pull request proposes to add an option "clientCredentials" which will send the client_id and client_secret in the Authorization header when the value is equal to "header".