Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify build system requirements #9

Open
wants to merge 1 commit into
base: oasis-master
Choose a base branch
from
Open

Conversation

buberdds
Copy link

@buberdds buberdds commented Jul 26, 2024

Did something change in Python stack? We are not able to use towncrier in CI (sample: https://github.com/oasisprotocol/explorer/actions/runs/10107648176/job/27951924406?pr=1491)

The error says that we are missing project metadata which relates to PEP 631. After adding metadata

[project]
    name = "towncrier"
    description = "Building newsfiles for your project."
    version="19.2.0"
    readme = "README.rst"
    license = { text = "MIT License" }

I was not able to build the project.

I ended up with specifying build system requirements (PEP 518). This is what towncrier was using before switching to hatchling twisted@65d25e0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L80.

I am not 100% what is the best way to tackle this in our 4-5yr old fork, but I am able to build and install towncier locally with this change.

@buberdds buberdds changed the title specify build system requirements Specify build system requirements Jul 26, 2024
@buberdds
Copy link
Author

The error is not happening anymore in CI. Will keep PR for now if problems occur again.

@buberdds buberdds mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant