Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-sdk: Add pending-withdrawal and pending-delegation addresses #1507

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Sep 22, 2023

This PR:

  • Mentions the pool address in the comments similar to how we do it in oasis-core.
  • Adds missing pending-withdrawal and pending-delegations addresses

Tag runtime-sdk/v0.8.4 after merge.

Blocked by #1617

Required by oasisprotocol/cli#134

@matevz matevz added the c:runtime-sdk Category: Runtime SDK label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87b7add) 61.47% compared to head (3060c61) 61.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   61.47%   61.47%           
=======================================
  Files         139      139           
  Lines        9907     9907           
=======================================
  Hits         6090     6090           
  Misses       3775     3775           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch from a80892d to ae0fd93 Compare September 22, 2023 10:38
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch from ae0fd93 to 667540a Compare September 22, 2023 11:19
@matevz matevz changed the title runtime-sdk: Put explicit rewards pool address in the comment runtime-sdk, client-sdk: Explicit rewards pool address in the comment, new pool literals Sep 22, 2023
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch 2 times, most recently from bcb4aa4 to 776b24f Compare January 24, 2024 15:44
@matevz matevz changed the title runtime-sdk, client-sdk: Explicit rewards pool address in the comment, new pool literals runtime-sdk, client-sdk: Migrate ResolveAddress to Oasis CLI, minor pool address additions Jan 25, 2024
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch 2 times, most recently from 56d452a to 46c6f73 Compare January 25, 2024 15:02
@matevz matevz changed the title runtime-sdk, client-sdk: Migrate ResolveAddress to Oasis CLI, minor pool address additions runtime-sdk, client-sdk: Pool address comments, add pending- instances to go Jan 25, 2024
@matevz matevz changed the title runtime-sdk, client-sdk: Pool address comments, add pending- instances to go client-sdk: Add pending-withdrawal and pending-delegations addresses to go Jan 25, 2024
@matevz matevz changed the title client-sdk: Add pending-withdrawal and pending-delegations addresses to go client-sdk: Add pending-withdrawal and pending-delegations addresses Jan 25, 2024
@matevz matevz changed the title client-sdk: Add pending-withdrawal and pending-delegations addresses client-sdk: Add pending-withdrawal and pending-delegation addresses Jan 25, 2024
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch 4 times, most recently from 22ffef0 to 7b4d142 Compare January 26, 2024 07:47
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch from bab35d1 to 94444ac Compare January 26, 2024 09:16
@matevz matevz force-pushed the matevz/docs/rewards-pool-address branch from 94444ac to 3060c61 Compare January 26, 2024 09:16
@matevz matevz enabled auto-merge January 26, 2024 09:21
@matevz matevz merged commit 21e8dc1 into main Jan 26, 2024
28 checks passed
@matevz matevz deleted the matevz/docs/rewards-pool-address branch January 26, 2024 09:40
github-actions bot added a commit that referenced this pull request Jan 26, 2024
…atevz/docs/rewards-pool-address

client-sdk: Add pending-withdrawal and pending-delegation addresses 21e8dc1
github-actions bot added a commit that referenced this pull request Jan 26, 2024
…/matevz/docs/rewards-pool-address

client-sdk: Add pending-withdrawal and pending-delegation addresses 21e8dc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime-sdk Category: Runtime SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants