-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-sdk: Add pending-withdrawal and pending-delegation addresses #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
September 22, 2023 09:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
Coverage 61.47% 61.47%
=======================================
Files 139 139
Lines 9907 9907
=======================================
Hits 6090 6090
Misses 3775 3775
Partials 42 42 ☔ View full report in Codecov by Sentry. |
peternose
approved these changes
Sep 22, 2023
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
from
September 22, 2023 10:38
a80892d
to
ae0fd93
Compare
peternose
approved these changes
Sep 22, 2023
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
from
September 22, 2023 11:19
ae0fd93
to
667540a
Compare
matevz
changed the title
runtime-sdk: Put explicit rewards pool address in the comment
runtime-sdk, client-sdk: Explicit rewards pool address in the comment, new pool literals
Sep 22, 2023
peternose
reviewed
Sep 22, 2023
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
2 times, most recently
from
January 24, 2024 15:44
bcb4aa4
to
776b24f
Compare
matevz
changed the title
runtime-sdk, client-sdk: Explicit rewards pool address in the comment, new pool literals
runtime-sdk, client-sdk: Migrate ResolveAddress to Oasis CLI, minor pool address additions
Jan 25, 2024
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
2 times, most recently
from
January 25, 2024 15:02
56d452a
to
46c6f73
Compare
matevz
changed the title
runtime-sdk, client-sdk: Migrate ResolveAddress to Oasis CLI, minor pool address additions
runtime-sdk, client-sdk: Pool address comments, add pending- instances to go
Jan 25, 2024
matevz
changed the title
runtime-sdk, client-sdk: Pool address comments, add pending- instances to go
client-sdk: Add pending-withdrawal and pending-delegations addresses to go
Jan 25, 2024
matevz
changed the title
client-sdk: Add pending-withdrawal and pending-delegations addresses to go
client-sdk: Add pending-withdrawal and pending-delegations addresses
Jan 25, 2024
matevz
changed the title
client-sdk: Add pending-withdrawal and pending-delegations addresses
client-sdk: Add pending-withdrawal and pending-delegation addresses
Jan 25, 2024
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
4 times, most recently
from
January 26, 2024 07:47
22ffef0
to
7b4d142
Compare
ptrus
reviewed
Jan 26, 2024
ptrus
approved these changes
Jan 26, 2024
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
from
January 26, 2024 08:39
7b4d142
to
bab35d1
Compare
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
from
January 26, 2024 09:16
bab35d1
to
94444ac
Compare
matevz
force-pushed
the
matevz/docs/rewards-pool-address
branch
from
January 26, 2024 09:16
94444ac
to
3060c61
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 26, 2024
…atevz/docs/rewards-pool-address client-sdk: Add pending-withdrawal and pending-delegation addresses 21e8dc1
github-actions bot
added a commit
that referenced
this pull request
Jan 26, 2024
…/matevz/docs/rewards-pool-address client-sdk: Add pending-withdrawal and pending-delegation addresses 21e8dc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Tag
runtime-sdk/v0.8.4
after merge.Blocked by #1617
Required by oasisprotocol/cli#134