Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: Always rollback any changes to storage from queries #1460

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 22, 2023

Note that in practice this is a no-op as Oasis Core will perform the rollback in any case. This just makes it explicit.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1460 (8a8d511) into main (c450763) will decrease coverage by 1.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   57.74%   56.34%   -1.41%     
==========================================
  Files         136      136              
  Lines        9767     9749      -18     
==========================================
- Hits         5640     5493     -147     
- Misses       4085     4214     +129     
  Partials       42       42              
Files Changed Coverage Δ
runtime-sdk/src/dispatcher.rs 18.50% <100.00%> (+0.42%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in practice this is a no-op as Oasis Core will perform the rollback in any case. This just makes it explicit.

I would add this as a comment, but saying that this is probably a no-op (as we can change the core code in the future).

Note that in practice this is a no-op as Oasis Core will perform the
rollback in any case. This just makes it explicit.
@kostko kostko force-pushed the kostko/fix/query-store-rollback branch from d424b81 to 8a8d511 Compare August 22, 2023 15:28
@kostko kostko enabled auto-merge August 22, 2023 15:28
@kostko kostko merged commit 1f8edd8 into main Aug 22, 2023
26 of 27 checks passed
@kostko kostko deleted the kostko/fix/query-store-rollback branch August 22, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants