rosetta-cli 0.4.0 and construction tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
force-pushed
the
pro-wh/feature/cli4
branch
from
215acd8 to
bdd4436
Compare
pro-wh
commented
Aug 4, 2020
| @@ -5,8 +5,11 @@ go 1.14 | |||
| replace github.com/tendermint/tendermint => github.com/oasisprotocol/tendermint v0.33.4-oasis2 | |||
|
|
|||
| require ( | |||
| github.com/coinbase/rosetta-sdk-go v0.3.0 | |||
| github.com/coinbase/rosetta-cli v0.4.0 | |||
There was a problem hiding this comment.
some of this stuff is dev only, used in tests/check-prep
pro-wh
force-pushed
the
pro-wh/feature/cli4
branch
from
bdd4436 to
0d0e503
Compare
|
apparently this isn't very stable. CI doesn't even run to the timeout. it died with this on the last run https://github.com/oasisprotocol/oasis-core-rosetta-gateway/runs/951623871#step:5:2374: |
|
Could it be related to transaction submission blocking, see #24? |
kostko
approved these changes
Aug 6, 2020
|
I'm going to split out enabling the check:construction into a separate PR |
pro-wh
force-pushed
the
pro-wh/feature/cli4
branch
from
eb85a2e to
1d7d95b
Compare
pro-wh
force-pushed
the
pro-wh/feature/cli4
branch
from
1d7d95b to
a1cf329
Compare
run rosetta-cli check:construction in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's changes for rosetta-cli 0.4.0. it's gonna be an awkward battle to get this integrated
fixes #25
cross-reference #23