Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain version #1167

Merged
merged 2 commits into from
Nov 10, 2018
Merged

Update rust toolchain version #1167

merged 2 commits into from
Nov 10, 2018

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Nov 10, 2018 •
edited
Loading

also fixes #1168

@nhynes nhynes requested a review from willscott November 10, 2018 03:43
@codecov
Copy link

codecov bot commented Nov 10, 2018 •
edited
Loading

Codecov Report

Merging #1167 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   56.47%   56.49%   +0.01%     
==========================================
  Files         121      121              
  Lines        9159     9159              
==========================================
+ Hits         5173     5174       +1     
+ Misses       3458     3457       -1     
  Partials      528      528
Impacted Files Coverage Δ
go/tendermint/tendermint.go 70.4% <0%> (-0.45%) ⬇️
go/scheduler/tests/tester.go 94.28% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97339d...dd06fe6. Read the comment docs.

@nhynes
Copy link
Contributor Author

nhynes commented Nov 10, 2018

proof of build:

screen shot 2018-11-10 at 11 05 19 am

@nhynes nhynes requested a review from peterjgilbert November 10, 2018 04:28
@nhynes nhynes merged commit 0d50f62 into master Nov 10, 2018
@nhynes nhynes deleted the update-rust branch November 10, 2018 05:23
@kostko kostko mentioned this pull request Nov 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjgilbert peterjgilbert peterjgilbert approved these changes

@willscott willscott Awaiting requested review from willscott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI should rebuild rust when toolchain version changes
2 participants
@nhynes @peterjgilbert