feature: Add initial support for runtime rofl transactions #812
Conversation
ptrus
force-pushed
the
ptrus/feature/rofl-txs-events
branch
3 times, most recently
from
e57976e to
fa87391
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/rofl-txs-events
branch
from
fa87391 to
5ccc938
Compare
ptrus
force-pushed
the
ptrus/feature/rofl-txs-events
branch
from
5ccc938 to
df2f5c0
Compare
ptrus
force-pushed
the
ptrus/feature/rofl-txs-events
branch
from
df2f5c0 to
97f8baa
Compare
There was a problem hiding this comment.
Nice, the Explorer folks might be interested in designing iconography for rofl transactions. cc @csillag
| case "rofl.Create": | ||
| if handler.RoflCreate != nil { | ||
| var body rofl.Create | ||
| if err := cbor.Unmarshal(call.Body, &body); err != nil { | ||
| return fmt.Errorf("unmarshal rofl create: %w", err) | ||
| } | ||
| if err := handler.RoflCreate(&body); err != nil { | ||
| return fmt.Errorf("rofl create: %w", err) | ||
| } | ||
| } | ||
| case "rofl.Update": | ||
| if handler.RoflUpdate != nil { | ||
| var body rofl.Update | ||
| if err := cbor.Unmarshal(call.Body, &body); err != nil { | ||
| return fmt.Errorf("unmarshal rofl update: %w", err) | ||
| } | ||
| if err := handler.RoflUpdate(&body); err != nil { | ||
| return fmt.Errorf("rofl update: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there any relevant information in the CallResult for rofl transactions? Or is it left for a future ticket?
There was a problem hiding this comment.
"rofl.Create" has App ID, others are empty. But we don't have anything to do with it at the moment, will leave it as a followup #807
| @@ -0,0 +1,9 @@ | |||
| feature: Add support for runtime rofl transactions | |||
|
|
|||
| New runtime transactions: | |||
There was a problem hiding this comment.
Not an ask for this PR, but we should think about adding another e2e regression suite that encompasses rofl/sapphire/consensusaccount txs and the rest of the new features being added :)
Already in progress oasisprotocol/explorer#1641 |
ptrus
force-pushed
the
ptrus/feature/rofl-txs-events
branch
from
97f8baa to
4684659
Compare
Fixes: #806
There were already some ROFL apps deployed on testnet for sapphire, so until we reindex, we will miss those transactions/events for now.
It is also possible to write a script that goes over runtime transactions and events for Sapphire and backfills the rofl events and transactions if we won't do a reindex and will still want the missed data - we can do this at a a later time.
For forntend, just displaying the transations.body and formating the events nicely will probably be good for first version.