Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Use global logging config everywhere #621

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

mitjat
Copy link
Contributor

@mitjat mitjat commented Feb 1, 2024

This PR has two related small improvements to logging:

  • We used NewDefaultLogger in a few places before; this is not great as the default logger does not reflect the .yml config (e.g. the desired logging level, the format, etc). We now use RootLogger (which is derived from the config) instead.
  • pogreb was logging straight to stderr, so all its info-level logs were interpreted as errors by GCP, and stood out in the log browser. We now route pogreb logs through our JSON-formatted logger, at INFO level.

@mitjat mitjat force-pushed the mitjat/pogreb-logging branch from 5f463c1 to 22991dc Compare February 1, 2024 05:59
@mitjat mitjat merged commit 8819303 into main Feb 1, 2024
9 checks passed
@mitjat mitjat deleted the mitjat/pogreb-logging branch February 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants