analyzer/block: Preemptively terminate batch before timeout #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
approved these changes
Jan 19, 2024
Andrew7234
approved these changes
Jan 19, 2024
mitjat
force-pushed
the
mitjat/preemptive-batch-terminate
branch
from
55b6b49 to
be89e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In slow sync, blocks arrive slowly, so the analyzer is almost always in the middle of processing a batch of blocks when the batchContext (5 minutes) times out. Every so often, the analyzer is also right in the middle of analyzing a block or writing it to the DB. When that happens, the block fails. This is harmless as the block is then retried, but looks ugly/alarming in the logs.
This PR makes the analyzer end the batch when the batchContext is merely close to expiring.