analyzer/runtime: Register special runtime addresses #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
requested review from
aefhm,
Andrew7234,
pro-wh and
ptrus
as code owners
Andrew7234
approved these changes
Sep 13, 2023
pro-wh
approved these changes
Sep 13, 2023
mitjat
force-pushed
the
mitjat/register-special-runtime-addresses
branch
from
0b3f4b3 to
deada27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while reading through the (de)bonding code in the runtime-sdk.
I'm not sure these address preimages are even surfaced anywhere in our API (because they're not eth preimages), but it can be helpful to have them when interpreting/debugging txs and events manually.
Related thought: It would be nice to surface these on the frontend also. Since it's a small set of completely static addresses, I think it's best to keep it simple and hardcode them in the frontend code somewhere.