[api] return evm address instead of oasis addr in RuntimeEvmBalance #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
force-pushed
the
andrew7234/runtime-account-evm-balance
branch
from
52f134a to
70d3234
Compare
ptrus
reviewed
Jul 20, 2023
ptrus
approved these changes
Jul 20, 2023
If we do that, it's a breaking change, which would need synchronized Nexus and Explorer releases to avoid breakage. I think adding Also, we have a switch on Explorer UI (well, at least for some parts) that supports choosing displaying Oasis and ETH addresses, according to the user's preferences. So having the Oasis address ready is definitely a plus. |
|
Thanks, I like this version much better! |
|
This will be used by oasisprotocol/explorer#762. |
Andrew7234
force-pushed
the
andrew7234/runtime-account-evm-balance
branch
3 times, most recently
from
845d216 to
595c70c
Compare
mitjat
approved these changes
Jul 25, 2023
Andrew7234
force-pushed
the
andrew7234/runtime-account-evm-balance
branch
from
595c70c to
57d2972
Compare
Andrew7234
force-pushed
the
andrew7234/erc-event-info
branch
from
1ff636c to
1c2e9a3
Compare
Andrew7234
force-pushed
the
andrew7234/runtime-account-evm-balance
branch
from
57d2972 to
9f43769
Compare
Andrew7234
force-pushed
the
andrew7234/erc-event-info
branch
from
1c2e9a3 to
b661cdc
Compare
[api] add runtimeEvmBalance.token_contract_addr_eth instead of replacing nit
Andrew7234
force-pushed
the
andrew7234/runtime-account-evm-balance
branch
from
9f43769 to
f578b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the openapi spec, the token_contract_address in
RuntimeEvmBalanceshould be the EVM address and not the oasis address.Need to confirm with explorer team that the currently returned oasis address can be replaced by the evm address. If not, we can return both the oasis and evm addresses (though the oasis address can be derived from the eth address).