Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: read token name #444

Merged
merged 1 commit into from
Jun 13, 2023
Merged

storage: read token name #444

merged 1 commit into from
Jun 13, 2023

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Jun 12, 2023 •
edited
Loading

reported by @csillag

tested locally on a sequence of ~200 blocks in mainnet emerald with known token activity

@pro-wh pro-wh added bug Something isn't working api-layer API layer-related issues. labels Jun 12, 2023
@pro-wh pro-wh force-pushed the pro-wh/bugfix/tokenname branch from 87bf86c to 6c5fb21 Compare June 12, 2023 17:16
@csillag
Copy link
Contributor

csillag commented Jun 12, 2023

👍🏻

mitjat
mitjat approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment •
edited by csillag
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

And thank you also for describing the testing regime. Will be nice to see this reflected in e2e tests once #519 is resolved ...

@pro-wh pro-wh merged commit 2fef00c into main Jun 13, 2023
@pro-wh pro-wh deleted the pro-wh/bugfix/tokenname branch June 13, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjat mitjat mitjat approved these changes

@aefhm aefhm Awaiting requested review from aefhm

@Andrew7234 Andrew7234 Awaiting requested review from Andrew7234 Andrew7234 is a code owner

Assignees
No one assigned
Labels
api-layer API layer-related issues. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pro-wh @csillag @mitjat