analyzer: fix evm.Create result type cutting #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
approved these changes
May 4, 2023
mitjat
approved these changes
May 4, 2023
There was a problem hiding this comment.
Nice sleuthing! Thank you!
Can you describe testing in the PR description please? I assume you did an e2e check, i.e. looked at the to field of a Create tx, as defined by our docs?
In the near future we'll have a regression dataset checked in, and the changes to those files will be proof enough 👍
|
oh I should make sure the API works too. I've only run the analyzer and looked in the database |
|
💀 the sender_0_eth and the to_eth are wrong |
pro-wh
force-pushed
the
pro-wh/bugfix/cleanup
branch
from
04ab871 to
1b079f5
Compare
pro-wh
force-pushed
the
pro-wh/bugfix/createcut
branch
from
31de271 to
0ff99d4
Compare
pro-wh
force-pushed
the
pro-wh/bugfix/cleanup
branch
from
1b079f5 to
326e664
Compare
pro-wh
force-pushed
the
pro-wh/bugfix/createcut
branch
from
0ff99d4 to
d5bc419
Compare
|
_eth addrs fixed in #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the result is the address, not the address embedded in a 256-bit thing. just the address. don't look for 32 bytes, don't cut it.
tested on a recent evm.Create transaction that occurred on mainnet Emerald, verified that the
tocolumn in the runtime_transactions table was populated, verified eth addresses displayed in API against another block explorer