Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: enable offline cache-based runtimeClient #396

Merged
merged 1 commit into from
May 1, 2023

Conversation

Andrew7234
Copy link
Collaborator

@Andrew7234 Andrew7234 commented May 1, 2023

After #390 the clunky runtimeInfo/sdkPT config was removed, which allows us to easily instantiate a cache-based runtimeClient without attempting to connect to a node (eg in CI).

Solves #855

@Andrew7234 Andrew7234 requested review from aefhm, mitjat and pro-wh as code owners May 1, 2023 22:44
Copy link
Collaborator

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

@Andrew7234 Andrew7234 force-pushed the andrew7234/cleanup branch from 92c8d8e to 6dcdd72 Compare May 1, 2023 23:47
@Andrew7234 Andrew7234 enabled auto-merge May 1, 2023 23:47
@Andrew7234 Andrew7234 merged commit 82e29b8 into main May 1, 2023
@Andrew7234 Andrew7234 deleted the andrew7234/cleanup branch May 1, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants