refactor: Remove QueryFactory #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
approved these changes
Mar 4, 2023
ptrus
reviewed
Mar 4, 2023
mitjat
force-pushed
the
mitjat/db-schema-no-oasis3
branch
from
6f288b5 to
c9a1636
Compare
mitjat
force-pushed
the
mitjat/query-factory-kill
branch
from
fa3cea2 to
cd60eb1
Compare
mitjat
force-pushed
the
mitjat/db-schema-no-oasis3
branch
from
c9a1636 to
77866be
Compare
mitjat
force-pushed
the
mitjat/query-factory-kill
branch
from
cd60eb1 to
f27c76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #341 now that it is no longer required to know the ChainID to query the DB.
This PR removes the QueryFactory (QF) abstraction. It was hardly needed any more after its main parameter (chainID) was rendered obsolete. The remaining uses of QueryFactory's
runtimefield were converted so that the runtime is passed into each query as an explicit parameter.Benefits of killing QF:
A similar-to-QF lightweight templating approach remains in genesis.go. I didn't touch it because we'll majorly clean up its SQL generation (from manually stringifying args to using SQL templates) in an upcoming PR.
For reviewers: Code at most commits does not compile; I still left them there because they each represent a logical step, so it's easier to follow along (IMO).
Testing
I ran e2e_regressions; consensus and emerald ran for 100 blocks. None of the tested URLs found any differences.