Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: remove obsolete Event enum in favor of autogenerated one #281

Merged

Conversation

mitjat
Copy link
Contributor

@mitjat mitjat commented Jan 12, 2023

The Event enum was superseded by the openapi-derived one in #255 .
The Backend enum was obsoleted even earlier by a PR of mine that merged the Backend and Event enums.

This PR removes both of these obsolete enums, and updates usages of Event with usages of openapi-based ConsensusEventType.

I'm doing this on top of #277 so as to avoid merge conflicts. The PR doesn't compile but neither does the merge base; hopefully the PR itself doesn't introduce new compile errors.

Copy link
Collaborator

@Andrew7234 Andrew7234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Andrew7234 Andrew7234 merged commit 7d9ef85 into andrew7234/account-activity Jan 12, 2023
@Andrew7234 Andrew7234 deleted the mitjat/obsolete-event-type-enum branch January 12, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants