Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: make epoch end height optional #278

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

mitjat
Copy link
Contributor

@mitjat mitjat commented Jan 10, 2023

Fixes an oversight in original API design.

Querying /v1/consensus/epochs -- before (note the first epoch, i.e. the active one):

{"epochs":[{"id":13404,"start_height":8050156,"end_height":0},{"end_height":8050156,"id":13403,"start_height":8049556},{"end_height":8049556,"id":13402,"start_height":8048956}]}

After:

{"epochs":[{"id":13404,"start_height":8050156},{"end_height":8050156,"id":13403,"start_height":8049556},{"end_height":8049556,"id":13402,"start_height":8048956}]}

@mitjat mitjat force-pushed the mitjat/epoch-end-optional branch from 8247a6c to 89acd02 Compare January 10, 2023 12:55
@mitjat mitjat enabled auto-merge January 10, 2023 12:56
@mitjat mitjat merged commit fb7836a into main Jan 10, 2023
@mitjat mitjat deleted the mitjat/epoch-end-optional branch January 10, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants