Andrew7234/runtime tx denoms #726
Conversation
analyzer/runtime/runtime.go
Outdated
| } | ||
|
|
||
| // StringifyDenomination returns a string representation of the given denomination. | ||
| // This is simply the denomination's symbol; notably, for the native denomination, | ||
| // this is looked up from network config. | ||
| func (m *processor) StringifyDenomination(d sdkTypes.Denomination) string { | ||
| func StringifyDenomination(runtimeMetadata *sdkConfig.ParaTime, d sdkTypes.Denomination) string { |
There was a problem hiding this comment.
The alternative to this refactor would be to copy these methods to extract.go, which would leave us with duplicate processor.StringifyDenomination as well as a StringifyDenomination functions in the same package. Not sure which is cleaner/more idiomatic, open to suggestions.
There was a problem hiding this comment.
this looks fine. if we ever need it outside the runtime blocks analyzer, we can move it to analyzer/util. a lot of stringifiers are there
analyzer/runtime/runtime.go
Outdated
| } | ||
|
|
||
| // StringifyDenomination returns a string representation of the given denomination. | ||
| // This is simply the denomination's symbol; notably, for the native denomination, | ||
| // this is looked up from network config. | ||
| func (m *processor) StringifyDenomination(d sdkTypes.Denomination) string { | ||
| func StringifyDenomination(runtimeMetadata *sdkConfig.ParaTime, d sdkTypes.Denomination) string { |
There was a problem hiding this comment.
this looks fine. if we ever need it outside the runtime blocks analyzer, we can move it to analyzer/util. a lot of stringifiers are there
Andrew7234
force-pushed
the
andrew7234/runtime-tx-denoms
branch
3 times, most recently
from
1e3b4ce to
15faaac
Compare
|
Huh we still have damask emerald disabled in our e2e_regression tests. I tried again and still had errors trying to query historical balances in the runtime finalizeFastSync. The comment says we probably need to redeploy the archive node now that 5540 is merged, which seems to have happened. The archive node is on labs infra and is running this image tag, which was built 5mo ago and should have worked. Will file a follow-up ticket to investigate further |
update e2e_regression test cases rename runtimeMetadata -> sdkPT for consistency nits changelog
Andrew7234
force-pushed
the
andrew7234/runtime-tx-denoms
branch
from
79cc649 to
399f701
Compare
Adds denomination fields for runtime transactions as
fee_symbolandamount_symbol.Also updates
is_likely_native_token_xferflag to be more accurate, api: is_likely_native_token_transfer should be true only for staking.Transfer with native denomination