debonding_delegations: remove id from the table

.changelog/712.bugfix.md

@@ -0,0 +1 @@
+Fix handling of multiple debonding-delegations ending in the same epoch

analyzer/consensus/consensus.go

@@ -954,7 +954,7 @@ func (m *processor) queueEscrows(batch *storage.QueryBatch, data *stakingData) e
 			e.Escrow.String(),
 			e.Owner.String(),
 		)
-		batch.Queue(queries.ConsensusDebondingStartDebondingDelegationsInsert,
+		batch.Queue(queries.ConsensusDebondingStartDebondingDelegationsUpsert,
 			e.Escrow.String(),
 			e.Owner.String(),
 			e.DebondingShares.String(),

analyzer/consensus/genesis.go

@@ -244,7 +244,7 @@ func (mg *GenesisProcessor) addStakingBackendMigrations(batch *storage.QueryBatc
 		for _, delegator := range sortedAddressKeys(escrows) {
 			debondingDelegations := escrows[delegator]
 			for _, debondingDelegation := range debondingDelegations {
-				batch.Queue(queries.ConsensusDebondingStartDebondingDelegationsInsert,
+				batch.Queue(queries.ConsensusDebondingStartDebondingDelegationsUpsert,
 					delegatee.String(),
 					delegator.String(),
 					debondingDelegation.Shares.ToBigInt(),

analyzer/queries/queries.go

@@ -377,9 +377,11 @@ var (
     DELETE FROM chain.delegations
       WHERE delegatee = $1 AND delegator = $2 AND shares = 0`
 
-	ConsensusDebondingStartDebondingDelegationsInsert = `
+	ConsensusDebondingStartDebondingDelegationsUpsert = `
     INSERT INTO chain.debonding_delegations (delegatee, delegator, shares, debond_end)
-      VALUES ($1, $2, $3, $4)`
+      VALUES ($1, $2, $3, $4)
+    ON CONFLICT (delegatee, delegator, debond_end) DO
+      UPDATE SET shares = chain.debonding_delegations.shares + $3`
 
 	ConsensusReclaimEscrowBalanceUpdate = `
     UPDATE chain.accounts
@@ -388,16 +390,14 @@ var (
         escrow_total_shares_debonding = escrow_total_shares_debonding - $3
       WHERE address = $1`
 
-	// Network upgrades delays debonding by 1 epoch.
+	// debond_end IN ($4::bigint, $4::bigint - 1, 0) is used because:
+	// - Network upgrades delays debonding by 1 epoch.
+	// - Some very old events might not have the debond_end set, so we have 0 in the Db.
+	//   This should not be problematic in practice since nowadays we have fast-sync where
+	//   we skip inserting debonding delegations for old epochs, so we should not encounter this.
 	ConsensusDeleteDebondingDelegations = `
     DELETE FROM chain.debonding_delegations
-      WHERE id = (
-        SELECT id
-        FROM chain.debonding_delegations
-        WHERE
-          delegator = $1 AND delegatee = $2 AND shares = $3 AND debond_end IN ($4::bigint, $4::bigint - 1)
-        LIMIT 1
-      )`
+      WHERE delegator = $1 AND delegatee = $2 AND shares = $3 AND debond_end IN ($4::bigint, $4::bigint - 1, 0)`
 
 	ConsensusAllowanceChangeDelete = `
     DELETE FROM chain.allowances

storage/migrations/00_consensus.up.sql

@@ -239,7 +239,7 @@ CREATE INDEX ix_delegations_delegator ON chain.delegations(delegator);
 
 CREATE TABLE chain.debonding_delegations
 (
-  id         BIGSERIAL PRIMARY KEY,  -- index-internal ID
+  id         BIGSERIAL PRIMARY KEY,  -- index-internal ID -- removed in 20_consensus_debonding_delegations_id_remove.up.sql.
   delegatee  oasis_addr NOT NULL REFERENCES chain.accounts(address) DEFERRABLE INITIALLY DEFERRED,
   delegator  oasis_addr NOT NULL REFERENCES chain.accounts(address) DEFERRABLE INITIALLY DEFERRED,
   shares     UINT_NUMERIC NOT NULL,

storage/migrations/20_consensus_debonding_delegations_id_remove.up.sql

@@ -0,0 +1,48 @@
+BEGIN;
+
+-- Create the new debonding delegations table.
+CREATE TABLE chain.debonding_delegations_new
+(
+  delegatee  oasis_addr NOT NULL REFERENCES chain.accounts(address) DEFERRABLE INITIALLY DEFERRED,
+  delegator  oasis_addr NOT NULL REFERENCES chain.accounts(address) DEFERRABLE INITIALLY DEFERRED,
+  debond_end UINT63 NOT NULL,
+  shares     UINT_NUMERIC NOT NULL,
+  PRIMARY KEY (delegatee, delegator, debond_end)
+);
+
+-- Insert data from the old table into the new table, merging shares on conflict.
+-- Skip debonding delegations that already ended (old debonding delegations table was not pruned correctly in all cases).
+DO $$
+DECLARE
+  current_epoch UINT63;
+BEGIN
+  SELECT id INTO current_epoch
+  FROM chain.epochs
+  ORDER BY id DESC
+  LIMIT 1;
+
+  -- Step 3: Insert data from the old table into the new table, merging shares on conflict
+  INSERT INTO chain.debonding_delegations_new (delegatee, delegator, debond_end, shares)
+  SELECT delegatee,
+         delegator,
+         debond_end,
+         SUM(shares) as shares
+  FROM chain.debonding_delegations
+  WHERE debond_end > current_epoch
+  GROUP BY delegatee, delegator, debond_end
+  ON CONFLICT (delegatee, delegator, debond_end) DO UPDATE
+  SET shares = chain.debonding_delegations_new.shares + EXCLUDED.shares;
+END $$;
+
+-- Drop the old table and rename the new table.
+DROP TABLE chain.debonding_delegations;
+ALTER TABLE chain.debonding_delegations_new RENAME TO debonding_delegations;
+
+-- Grant others read-only use.
+-- (We granted already in 00_consensus.up.sql, but the grant does not apply to new tables.)
+GRANT SELECT ON ALL TABLES IN SCHEMA chain TO PUBLIC;
+GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA chain TO PUBLIC;
+GRANT SELECT ON ALL TABLES IN SCHEMA analysis TO PUBLIC;
+GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA analysis TO PUBLIC;
+
+COMMIT;