Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display TX format for unencrypted transactions #989

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Oct 31, 2023

We have already been displaying format for encrypted transactions, but not for plain ones.
I moved the field (for encrypted TXs) higher, right next to type, and added the same field for plain transactions, too.

Encrypted TX:

image

Plain TX:

image

@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Deployed to Cloudflare Pages

Latest commit: 7580b1fe2be5fb6f2dc3841f66bc4de1d16a3013
Status:✅ Deploy successful!
Preview URL: https://dd54f95b.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/display-unencrypted-format-for-tx-details branch from 342911c to a48537f Compare October 31, 2023 11:20
@csillag csillag marked this pull request as ready for review October 31, 2023 11:22
@csillag csillag requested review from lukaw3d and buberdds October 31, 2023 11:23
@csillag csillag force-pushed the csillag/display-unencrypted-format-for-tx-details branch from a48537f to 7580b1f Compare October 31, 2023 20:00
@csillag
Copy link
Contributor Author

csillag commented Oct 31, 2023

@donouwens approves.

@csillag csillag merged commit 45f6034 into master Oct 31, 2023
8 checks passed
@csillag csillag deleted the csillag/display-unencrypted-format-for-tx-details branch October 31, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants