Matomo Analytics (using localStorage) #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
reviewed
Oct 17, 2023
src/app/pages/HomePage/index.tsx
Outdated
| @@ -180,6 +181,7 @@ export const HomePage: FC = () => { | |||
| /> | |||
| </Box> | |||
| </ThemeByNetwork> | |||
| <CookieConsent /> | |||
There was a problem hiding this comment.
Doesn't appear in subpages http://localhost:1234/mainnet/sapphire
| })) | ||
|
|
||
| return ( | ||
| <Snackbar |
There was a problem hiding this comment.
Hm, maybe snackbar isn't optimal. Mobile users can't ignore and scroll past it
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Oct 22, 2023
|
rebased, going to force push |
pro-wh
force-pushed
the
kaja/matomo-tracking-implementation
branch
from
7740c8b to
803b2b0
Compare
pro-wh
force-pushed
the
kaja/matomo-tracking-implementation
branch
from
803b2b0 to
75775d2
Compare
lubej
reviewed
Feb 2, 2024
Comment on lines
+9
to
+36
| // Generate snippet https://matomo.oasis.io/index.php?module=CoreAdminHome&action=trackingCodeGenerator&idSite=1&period=day&date=yesterday&updated=false | ||
| // Snippet from https://developer.matomo.org/guides/tracking-javascript-guide#finding-the-piwik-tracking-code | ||
| window._paq = window._paq || [] | ||
| export const matomoDomain = 'https://matomo.oasis.io/' | ||
| // https://matomo.org/faq/how-to/faq_23654/ | ||
| window._paq.push(['setDomains', ['*.domain1.com', '*.domain2.com']]) | ||
| window._paq.push(['enableCrossDomainLinking']) | ||
| /* tracker methods like 'setCustomDimension' should be called before 'trackPageView' */ | ||
| window._paq.push(['setCookieDomain', '*.example.org']) | ||
| window._paq.push(['setDoNotTrack', true]) | ||
| window._paq.push(['enableLinkTracking']) | ||
| window._paq.push(['setTrackerUrl', `${matomoDomain}matomo.php`]) | ||
| window._paq.push(['setSiteId', '3']) | ||
|
|
||
| window._paq.push([ | ||
| 'setCustomRequestProcessing', | ||
| (queryString: string) => { | ||
| const params = new URLSearchParams(queryString) | ||
| for (const name of ['action_name', 'url', 'urlref']) { | ||
| const v = params.get(name) | ||
| if (v) { | ||
| params.set(name, redactURL(v)) | ||
| } | ||
| } | ||
|
|
||
| return params.toString() | ||
| }, | ||
| ]) |
There was a problem hiding this comment.
I would add this configuration to addMatomo function. And only set those config on consent.
There was a problem hiding this comment.
reason? we need these right away so that any custom _paq.push(...) come in after things are configured, otherwise they won't get anonymized etc. if a user subsequently opts in
lukaw3d
reviewed
Feb 19, 2024
| // Generate snippet https://matomo.oasis.io/index.php?module=CoreAdminHome&action=trackingCodeGenerator&idSite=1&period=day&date=yesterday&updated=false | ||
| // Snippet from https://developer.matomo.org/guides/tracking-javascript-guide#finding-the-piwik-tracking-code | ||
| window._paq = window._paq || [] | ||
| export const matomoDomain = 'https://matomo.oasis.io/' |
There was a problem hiding this comment.
New issue: pontusx.
I would just enable/disable our analytics with .env.production (instead of generalizing everything in env: matomoDomain, setDomains, setCookieDomain, setSiteId, sha384-)
There was a problem hiding this comment.
lukaw3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Cookie Banner visual component (without the tracking functionality)
Before:
After:
