Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently capitalize columns and description terms #810

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Consistently capitalize columns and description terms #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb0993
Consistently capitalize columns and description terms
lukaw3d Aug 21, 2023
4b98a2e
Update Transaction Fee text
lukaw3d Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/810.internal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Consistently capitalize columns and description terms
2 changes: 1 addition & 1 deletion src/app/components/Transactions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const Transactions: FC<TransactionsProps> = ({
{ key: 'type', content: t('common.type'), align: TableCellAlign.Center },
{ key: 'from', content: t('common.from'), width: '150px' },
{ key: 'to', content: t('common.to'), width: '150px' },
{ key: 'txnFee', content: t('common.txnFee'), align: TableCellAlign.Right, width: '250px' },
{ key: 'txnFee', content: t('common.transactionFee'), align: TableCellAlign.Right, width: '250px' },
{ key: 'value', align: TableCellAlign.Right, content: t('common.value'), width: '250px' },
]
: []),
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/TransactionDetailPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export const TransactionDetailView: FC<{
</>
)}

<dt>{t('common.txnFee')}</dt>
<dt>{t('common.transactionFee')}</dt>
<dd>
{t('common.valueInToken', {
...getPreciseNumberFormat(transaction.charged_fee),
Expand Down
10 changes: 5 additions & 5 deletions src/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@
"ethHash": "ETH hash",
"events": "Events",
"failed": "Failed",
"fiatValue": "Fiat value",
"fiatValue": "Fiat Value",
"fiatValueInUSD": "{{value, currency}}",
"fill": "Fill",
"formattedBlockTimestamp": "{{timestamp, dateTime}} ({{distance}})",
"formattedDateTime": "{{timestamp, dateTime}}",
"from": "From",
"gasUsed": "Gas used",
"gasLimit": "Gas limit",
"gasUsed": "Gas Used",
"gasLimit": "Gas Limit",
"hash": "Hash",
"height": "Height",
"hide": "Hide",
Expand Down Expand Up @@ -89,7 +89,7 @@
"totalSent": "Total Sent",
"transactions": "Transactions",
"transactionAbbreviation": "Txs",
"txnFee": "Txn Fee",
"transactionFee": "Transaction Fee",
"type": "Type",
"quantity": "Quantity",
"undefined": "Undefined",
Expand Down Expand Up @@ -217,7 +217,7 @@
"emptyTokenHolderList": "There are no token holders on record for this token.",
"holders": "Token Holders",
"holdersValue": "{{ value, number }}",
"holdersCount": "Holders count",
"holdersCount": "Holders Count",
"holdersCount_short": "Holders",
"totalSupply": "Total Supply",
"totalSupplyValue": "{{ value, number }}",
Expand Down