Improve performance when displaying token lists, using newly available data #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/optimize-token-list
branch
2 times, most recently
from
d9f9b94 to
4b66304
Compare
csillag
force-pushed
the
csillag/optimize-token-list
branch
from
4b66304 to
dd482e0
Compare
csillag
force-pushed
the
csillag/optimize-token-list
branch
3 times, most recently
from
84baf2c to
7010f78
Compare
|
Tested with latest staging Nexus deployment, seems to work fine. (For testing, I had to change the API endpoints to staging, and enable Emerald.) |
csillag
force-pushed
the
csillag/optimize-token-list
branch
4 times, most recently
from
fda7a5a to
8e883f1
Compare
|
Now that the relevant Nexus changes have been merged, this PR has also been updated accordingly. |
csillag
force-pushed
the
csillag/optimize-token-list
branch
from
8e883f1 to
464273a
Compare
lukaw3d
approved these changes
Aug 1, 2023
Don't send extra round-trips to ask data about the underlying contract, since verification data is now mirrored inside the token info.
csillag
force-pushed
the
csillag/optimize-token-list
branch
from
464273a to
c2717d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on oasisprotocol/nexus#493.This also depends on #761. (Since the Nexus PRs also depend on each other.)Please note that while this version is backward compatible with the currently deployed staging or production versions of nexus, the performance improvements will only be realized if the new version of nexus is deployed.