Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully bring back ERC-721 tokens #681

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jul 6, 2023

This PR basically just restores what we had before we have removed the ERC-721 support before in 3a3b71f, following the indexer (now nexus) API changes.

Now that nexus brings them back, we need to do that, too.

The previous PR (#679) fixed the type safety issues and exceptions; this PR adds back the missing UI.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Deployed to Cloudflare Pages

Latest commit: 454e1fd29b3da7f3af6c89cb8dca51ca8cf5eba6
Status:✅ Deploy successful!
Preview URL: https://7edf9ed4.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/fully-bring-back-ERC721-tokens branch from 0083ce6 to 809d199 Compare July 6, 2023 12:57
@csillag csillag marked this pull request as ready for review July 6, 2023 12:57
@csillag csillag requested review from lukaw3d and buberdds July 6, 2023 13:00
src/oasis-nexus/api.ts Outdated Show resolved Hide resolved
src/app/pages/AccountDetailsPage/index.tsx Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/fully-bring-back-ERC721-tokens branch from 809d199 to bd3cb98 Compare July 6, 2023 14:13
@csillag csillag force-pushed the csillag/fully-bring-back-ERC721-tokens branch from bd3cb98 to 454e1fd Compare July 6, 2023 14:13
@csillag csillag enabled auto-merge July 6, 2023 14:15
@csillag csillag merged commit d6accdd into master Jul 6, 2023
@csillag csillag deleted the csillag/fully-bring-back-ERC721-tokens branch July 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants