Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve token lists #638

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Improve token lists #638

merged 7 commits into from
Jul 3, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jul 1, 2023 •
edited
Loading

The PR improves the token lists in the following ways:

  • Include contract verification information (loaded asynchronously)
  • Fix token supply formatting (vertial view only)
  • Put the ticker/symbol next to the name (in vertical view only)
Before After
image image
--------- ------
image image

All approved by @donouwens)

I suggest reviewing this PR commit by commit,

@github-actions
Copy link

github-actions bot commented Jul 1, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 3818e4dfb6823d83fce1ca665ce78d3cb1665ef2
Status:✅ Deploy successful!
Preview URL: https://80e76fd8.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch from 00708a5 to 586240e Compare July 1, 2023 00:33
@csillag csillag marked this pull request as ready for review July 1, 2023 00:37
@csillag csillag mentioned this pull request Jul 1, 2023
Merged
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch 2 times, most recently from 22f197d to dc3c6af Compare July 1, 2023 10:07
@csillag
Copy link
Contributor Author

csillag commented Jul 1, 2023

@donouwens says that this is OK.

@csillag csillag requested review from lukaw3d and buberdds July 1, 2023 10:14
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch from dc3c6af to c918eca Compare July 2, 2023 19:47
@csillag csillag changed the title Include contract verification info in token lists Include contract verification info in token lists and other small improvements Jul 2, 2023
@csillag csillag changed the title Include contract verification info in token lists and other small improvements Token lists: Include contract verification info and other small improvements Jul 2, 2023
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch from c918eca to 75d22e8 Compare July 2, 2023 19:51
@csillag csillag changed the title Token lists: Include contract verification info and other small improvements Improve token lists Jul 2, 2023
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch 2 times, most recently from 24eb097 to 4b888c6 Compare July 3, 2023 09:06
lukaw3d
lukaw3d reviewed Jul 3, 2023
View reviewed changes
src/app/components/Account/ContractCreatorInfo.tsx Outdated Show resolved Hide resolved
src/app/components/Account/ContractVerificationInfo.tsx Outdated Show resolved Hide resolved
src/app/components/Account/ContractVerificationInfo.tsx Outdated Show resolved Hide resolved
src/app/components/Account/ContractVerificationInfo.tsx Outdated Show resolved Hide resolved
src/app/components/Account/index.tsx Show resolved Hide resolved
src/app/components/Tokens/TokenDetails.tsx Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch 5 times, most recently from 77fb72e to 56bfa67 Compare July 3, 2023 13:24
@csillag csillag requested a review from lukaw3d July 3, 2023 13:24
@csillag csillag force-pushed the csillag/verification-info-for-token-lists branch from 56bfa67 to 3818e4d Compare July 3, 2023 14:26
@csillag csillag merged commit 48e5791 into master Jul 3, 2023
@csillag csillag deleted the csillag/verification-info-for-token-lists branch July 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csillag @lukaw3d