Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double click on graph #583

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Prevent double click on graph #583

merged 4 commits into from
Jun 28, 2023

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jun 22, 2023

Double click on ecosystem has odd behaviour, double click navigates directly to Dashboard.

@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 068b45f5724c0665e558802747d6c0d10e9e55d3
Status:✅ Deploy successful!
Preview URL: https://9d021b87.oasis-explorer.pages.dev

@lubej lubej force-pushed the ml/prevent-double-click-on-graph branch from 301e1b9 to 64506f7 Compare June 22, 2023 09:13
@lubej lubej requested review from lukaw3d, buberdds and csillag and removed request for lukaw3d June 22, 2023 09:13
@lubej lubej marked this pull request as ready for review June 22, 2023 09:13
@lubej lubej force-pushed the ml/prevent-double-click-on-graph branch 2 times, most recently from 7736044 to 67150bc Compare June 22, 2023 11:04
@lukaw3d
Copy link
Member

lukaw3d commented Jun 22, 2023

Can you add instructions to reproduce double click navigates directly to Dashboard. I can't reproduce

@lubej
Copy link
Collaborator Author

lubej commented Jun 23, 2023

Can you add instructions to reproduce double click navigates directly to Dashboard. I can't reproduce

@lukaw3d unable to reproduce currently as well. Yesterday I was able to reproduce consistently.

@lubej
Copy link
Collaborator Author

lubej commented Jun 27, 2023

Can you add instructions to reproduce double click navigates directly to Dashboard. I can't reproduce

@lukaw3d unable to reproduce currently as well. Yesterday I was able to reproduce consistently.

@lukaw3d here is the reproduction: https://www.loom.com/share/c043399b62f043e1bd1e3860a020d762

@lukaw3d
Copy link
Member

lukaw3d commented Jun 27, 2023 •
edited by lubej
Loading

🤷 can't reproduce, but alright

Double click on ecosystem has odd behaviour
When double clicking on the ecosystem it zooms the image, but does not show the 'Zoom out' button.

@lubej lubej closed this Jun 27, 2023
@lubej lubej reopened this Jun 27, 2023
@lubej lubej force-pushed the ml/prevent-double-click-on-graph branch from 67150bc to 9f5e6ac Compare June 27, 2023 16:22
@lubej
Copy link
Collaborator Author

lubej commented Jun 27, 2023 •
edited
Loading

🤷 can't reproduce, but alright

Double click on ecosystem has odd behaviour
When double clicking on the ecosystem it zooms the image, but does not show the 'Zoom out' button.

Right, meant to create another PR for it, but just added it in here, as it relates.

@lubej lubej force-pushed the ml/prevent-double-click-on-graph branch from 92b610f to 5abcc73 Compare June 27, 2023 17:13
@lubej lubej force-pushed the ml/prevent-double-click-on-graph branch from 5abcc73 to 83e2043 Compare June 28, 2023 10:30
@lubej lubej enabled auto-merge June 28, 2023 10:30
@lubej lubej disabled auto-merge June 28, 2023 10:32
@lubej lubej merged commit 3cc7913 into master Jun 28, 2023
@lubej lubej deleted the ml/prevent-double-click-on-graph branch June 28, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

@csillag csillag Awaiting requested review from csillag csillag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubej @lukaw3d