Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use intlFormatDistance instead of formatDistanceToNow #565

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Use intlFormatDistance instead of formatDistanceToNow #565

merged 5 commits into from
Jun 27, 2023

Conversation

lubej
Copy link
Contributor

@lubej lubej commented Jun 20, 2023 •
edited
Loading

Before After
image image

@lubej lubej requested review from buberdds and lukaw3d June 20, 2023 12:48
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 735e1fd0ee8a9ceb616fe99804ecf2e0a2521451
Status:✅ Deploy successful!
Preview URL: https://e963eb93.oasis-explorer.pages.dev

@lukaw3d lukaw3d mentioned this pull request Jun 20, 2023
Merged
@lubej
Copy link
Contributor Author

lubej commented Jun 21, 2023

image

@lukaw3d here is the snapshot diff. Even though the current implementation, is not as granular. And there is no nice way to "block" quarters.

lukaw3d
lukaw3d reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/ quarters

src/app/utils/dateFormatter.ts Outdated Show resolved Hide resolved
src/app/utils/dateFormatter.ts Outdated Show resolved Hide resolved
src/app/utils/dateFormatter.ts Outdated Show resolved Hide resolved
src/app/utils/dateFormatter.ts Outdated Show resolved Hide resolved
@lukaw3d lukaw3d force-pushed the ml/use-date-fns-locatiozation-narrow branch from a881dfc to a6151cf Compare June 22, 2023 22:29
@lubej lubej marked this pull request as ready for review June 26, 2023 13:31
@lubej lubej force-pushed the ml/use-date-fns-locatiozation-narrow branch 2 times, most recently from 6299b97 to 5d3304c Compare June 26, 2023 15:15
@lubej lubej force-pushed the ml/use-date-fns-locatiozation-narrow branch from 02e7532 to 735e1fd Compare June 27, 2023 07:26
@lubej lubej enabled auto-merge June 27, 2023 07:26
@lubej lubej merged commit 3e5cd1f into master Jun 27, 2023
@lubej lubej deleted the ml/use-date-fns-locatiozation-narrow branch June 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubej @lukaw3d