Add strict type-checks that most switch statements cover all cases #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
commented
Jun 8, 2023
csillag
reviewed
Jun 8, 2023
| return ( | ||
| <div> | ||
| <div>{eventName}</div> | ||
| <pre>{JSON.stringify(event, null, ' ')}</pre> | ||
| </div> | ||
| ) | ||
| default: | ||
| throw new ExhaustedTypeError('Unexpected event type', event.type) |
There was a problem hiding this comment.
I'm not happy with throwing an error (and hence breaking the whole page) just because we see something we don't recognize. I thing we should also have an exhaustedTypeWarning() function, which just uses console.warn(), and use that in the milder cases like this one.
There was a problem hiding this comment.
Converted to warnings in production and errors in development
lukaw3d
force-pushed
the
lw/strict
branch
3 times, most recently
from
1c815e8 to
4c71566
Compare
csillag
reviewed
Jun 22, 2023
| default: | ||
| exhaustedTypeWarning('Unexpected layer', layer) | ||
| throw new AppError(AppErrors.UnsupportedLayer) |
There was a problem hiding this comment.
Here we are throwing two exceptions on quick succession. (At least in PROD mode.) Are they both necessary?
There was a problem hiding this comment.
Yes, unless we introduce more fallbacks
csillag
approved these changes
Jun 22, 2023
But only print a warning if encountered in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.