Retain ETH address in details page for accounts with no EVM transactions #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Oct 7, 2024
buberdds
force-pushed
the
mz/ethAddress
branch
2 times, most recently
from
f89a7a4 to
d856438
Compare
buberdds
changed the title
buberdds
force-pushed
the
mz/ethAddress
branch
2 times, most recently
from
781d415 to
95ffd9a
Compare
lukaw3d
reviewed
Oct 15, 2024
lukaw3d
reviewed
Oct 15, 2024
|
Something broke search: |
buberdds
force-pushed
the
mz/ethAddress
branch
from
ce1a0f6 to
2a8b270
Compare
|
Ok, search will behave the same way. |
|
Ooooh, so searching for "0x95D683e4365209E5ce64f2e26e00C23207fe7Ec3" would have still found the 4 results |
|
Yes, search functionality is not affected by this PR. For now we want to tweak account view with eth address once you navigate from dApp. Will look at search later this week. |
lukaw3d
reviewed
Oct 17, 2024
lukaw3d
reviewed
Oct 17, 2024
lukaw3d
approved these changes
Oct 17, 2024
lukaw3d
force-pushed
the
mz/ethAddress
branch
from
3ed9f96 to
5bbd54f
Compare
buberdds
force-pushed
the
mz/ethAddress
branch
from
5bbd54f to
65a9de7
Compare
buberdds
force-pushed
the
mz/ethAddress
branch
from
65a9de7 to
5a3a25d
Compare
lukaw3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised by Tadej (while using staker dApp as far as I remember) / for frontend sync meeting.
acc without
address_preimage(keep eth addr)https://pr-1564.oasis-explorer.pages.dev/mainnet/sapphire/address/0x95D683e4365209E5ce64f2e26e00C23207fe7Ec3
https://explorer.dev.oasis.io/mainnet/sapphire/address/0x95D683e4365209E5ce64f2e26e00C23207fe7Ec3
acc with
address_preimage(works the same way)https://pr-1564.oasis-explorer.pages.dev/mainnet/sapphire/address/0x8Bba8906467831962Ed5E524F4Bc47733CBF3b27
https://explorer.dev.oasis.io/mainnet/sapphire/address/0x8Bba8906467831962Ed5E524F4Bc47733CBF3b27
Notes: (thx @Andrew7234)