Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lists with polling and pagination more stable #1534

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Make lists with polling and pagination more stable #1534

merged 4 commits into from
Oct 7, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Sep 11, 2024 •
edited
Loading

Issue discussed during planning yesterday (not 100% sure what requirements are)

  • keep polling on 1st pages so user can see incoming items (green rows)
  • kill polling on other pages
  • make lists "static" when using pagination by keeping timestamp and using it in before API param
  • page 1 relies on data returned by collection to avoid polling status endpoint
  • other pages relies on status endpoint and latest_block_time which seems to work fine in views

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 84ab80b9cece2f2a60b17d81fe4ddaf3bcb0c163
Status:✅ Deploy successful!
Preview URL: https://82f64baa.oasis-explorer.pages.dev
Alias: https://pr-1534.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/useBeforeDate branch 2 times, most recently from 94630eb to a98f604 Compare September 11, 2024 08:10
@buberdds buberdds changed the title Make lists with polling and pagination more stable WIP: Make lists with polling and pagination more stable Sep 11, 2024
@buberdds buberdds force-pushed the mz/useBeforeDate branch 4 times, most recently from 5b4e778 to f8fda4f Compare September 11, 2024 09:25
@buberdds buberdds changed the title WIP: Make lists with polling and pagination more stable Make lists with polling and pagination more stable Sep 11, 2024
@buberdds buberdds force-pushed the mz/useBeforeDate branch 5 times, most recently from b843fbb to da66d12 Compare September 17, 2024 08:10
@buberdds buberdds force-pushed the mz/useBeforeDate branch 2 times, most recently from 7ab0175 to 913116f Compare October 3, 2024 10:20
lukaw3d
lukaw3d approved these changes Oct 4, 2024
View reviewed changes
src/app/hooks/useListBeforeDate.ts Show resolved Hide resolved
src/app/hooks/useListBeforeDate.ts Outdated Show resolved Hide resolved
@buberdds buberdds force-pushed the mz/useBeforeDate branch 2 times, most recently from 48de54b to 613319d Compare October 7, 2024 07:44
@buberdds buberdds merged commit 0324c81 into master Oct 7, 2024
8 checks passed
@buberdds buberdds deleted the mz/useBeforeDate branch October 7, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@csillag csillag Awaiting requested review from csillag csillag is a code owner

@lubej lubej Awaiting requested review from lubej lubej is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buberdds @lukaw3d