Add details column to Consensus transactions list #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/newtxList
branch
2 times, most recently
from
f908397 to
cc002d4
Compare
|
Not ready for review. Need to talk to Don first. |
buberdds
changed the title
buberdds
force-pushed
the
mz/newtxList
branch
7 times, most recently
from
2e84e7b to
ce95725
Compare
buberdds
changed the title
lukaw3d
approved these changes
Jul 24, 2024
| return ( | ||
| <> | ||
| <From address={transaction.sender} ownAddress={ownAddress} scope={scope} /> | ||
| <LabelValue label={t('common.id')} value={transaction.body?.id} trimMobile /> |
There was a problem hiding this comment.
This can be matched to runtime ids
Line 102 in a01b899
There was a problem hiding this comment.
yes body.id is always runtime id in executor commits. Why should I match this value with a config value?
There was a problem hiding this comment.
discussed during sync meeting:
- define tx details and labels (planning meeting)
- map runtime id to a name (separate PR)
- use ValidatorLink instead AccountLink where needed
src/app/components/Transactions/ConsensusTransactionDetails.tsx
Outdated
Show resolved
Hide resolved
lukaw3d
reviewed
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConsensusTransactionDetails)TODO: