Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account details: add link to validator details #1466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 28, 2024

This is relevant when we are displaying a consensus account
that belongs to a validator.

@csillag csillag force-pushed the csillag/account-delegator-link branch from 93929b8 to 59838ea Compare June 28, 2024 17:27
@csillag csillag marked this pull request as ready for review June 28, 2024 17:27
@csillag csillag changed the title Account details: add link to validator details. Account details: add link to validator details Jun 28, 2024
@csillag csillag force-pushed the csillag/account-delegator-link branch from 59838ea to 1475704 Compare June 28, 2024 20:02
Copy link

github-actions bot commented Jun 28, 2024

Deployed to Cloudflare Pages

Latest commit: 5e99f5208c59adeb44d5728f2601d3e2b2497fdd
Status:✅ Deploy successful!
Preview URL: https://e058c172.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/account-delegator-link branch from 1475704 to ccdb9a6 Compare June 28, 2024 20:14
@csillag csillag force-pushed the csillag/account-delegator-link branch from ccdb9a6 to 5e99f52 Compare July 1, 2024 09:53
@csillag
Copy link
Contributor Author

csillag commented Jul 1, 2024

Design validated by @donouwens

@buberdds
Copy link
Contributor

buberdds commented Jul 1, 2024

Designs include:

  • some icon next to a validator name
  • this should be added in multiple places. I am not sure what are these places after the latest changes in Figma: other than account details we need account list update. What about search results or account list - vertical list?

@donouwens
Copy link
Collaborator

Designs include:

  • some icon next to a validator name
  • this should be added in multiple places. I am not sure what are these places after the latest changes in Figma: other than account details we need account list update. What about search results or account list - vertical list?

It should also be added on the account overview pages, search results, account section on the dashboard, transactions.

@csillag csillag self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants