Display EVM addresses in events

[lubej]

Related to oasisprotocol/nexus#653

Description

This pull request addresses the issue, where custom events do not take into account address type toggle.

Account to test with:
testnet/sapphire/tx/0x8a99091101d5ee03c3e120ee222eaafcff6715a324c3936f88e733231e1c3ea5

[github-actions]

Deployed to Cloudflare Pages

Latest commit:	05b290febd6ad5af73e81e7ff43c3d9a9a46ec58
Status:	✅ Deploy successful!
Preview URL:	https://b3ccba1a.oasis-explorer.pages.dev

[lukaw3d]

Ideally it should add a tooltip too. See

explorer/src/app/pages/RuntimeTransactionDetailPage/index.tsx

Lines 272 to 291 in 12e6c6f

	<dd>
	<TransactionInfoTooltip
	label={
	from
	? isOasisAddressFormat
	? t('transaction.tooltips.senderTooltipOasis')
	: t('transaction.tooltips.senderTooltipEth')
	: t('transaction.tooltips.senderTooltipUnavailable')
	}
	>
	<AccountLink
	scope={transaction}
	address={
	from ||
	((isOasisAddressFormat ? transaction?.sender_0_eth : transaction?.sender_0) as string)
	}
	/>
	</TransactionInfoTooltip>
	{from && <CopyToClipboard value={from} />}
	</dd>

[lukaw3d]

Ah, but the tooltip text is annoyingly specific (senderTooltipOasis, senderTooltipEth)

[lubej]

Great point, but I think this should be included in the events as well. Even though I doubt the "validity" of it, in a sense, how much additional information it adds. But I guess we decided on this for a reason.

[lubej]

Did add the tooltip inside withAddressSwitch, but I am unsure of naming, to make it generic. Should we accept translations as an input? As withAddressSwitch can be used as generic component, that could technically wrap TransactionLink.

[lukaw3d]

I think having them as input shouldn't be too much overhead

[lukaw3d]

(in the current state of labels, it doesn't add much information, except when hovering transaction hash. Oasis transaction hashes don't have an obvious "oasis1" prefix)

[lubej]

Yeah, wanted to discuss on next frontend sync, what labels we want and even if we want them(can always add them later) - and just remove the Tooltip for now. Will ping @donouwens next week.

[lubej]

Removed Tooltip for now, as I probably won't be able to make it to the next FE sync + Don as well. So we can discuss on the next one, that we are all able to join. Just want to get this ready for release before the conference.