Fix oasis address links even when toggled to ETH addresses #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
reviewed
Mar 18, 2024
| ) : ( | ||
| <Link component={RouterLink} to={to}> | ||
| <Link component={RouterLink} to={to} sx={{ fontWeight: plain ? 400 : undefined }}> |
There was a problem hiding this comment.
all links should be 700 according to Don (same for TransactionLink). If that is true, why we even need plain?
I am a bit confused what plain is doing now (in master not this PR). We render (...)Link component and we use that prop to not render a link?
There was a problem hiding this comment.
all links should be 700 according to Don (same for TransactionLink). If that is true, why we even need plain?
fixed
I am a bit confused what plain is doing now (in master not this PR). We render (...)Link component and we use that prop to not render a link?
in most cases it displayed just text instead of a link, I guess so that toggling to ETH addresses would not contain confusing oasis1 addresses 🤷
lukaw3d
force-pushed
the
lw/fix-oasis-links
branch
from
d0c547f to
58ebf20
Compare
Makes "plain" links still link to the address. User might not have known they needed to toggle the address format before they could open a "plain" address. Fixes #1220: oasis addresses in e.g. consensus deposit transactions in EVM runtimes were not clickable in mobile vertical layout of transactions because it is implicitly toggled to ETH addresses (and can't be toggled to Oasis).
lukaw3d
force-pushed
the
lw/fix-oasis-links
branch
from
58ebf20 to
243c96f
Compare
buberdds
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes "plain" links still link to the address. User might not have known they needed to toggle the address format before they could open a "plain" address.
Fixes #1220: oasis addresses in e.g. consensus deposit transactions in EVM runtimes were not clickable in mobile vertical layout of transactions because it is implicitly toggled to ETH addresses (and can't be toggled to Oasis).