-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Consensus routing #1129
Enable Consensus routing #1129
Conversation
Deployed to Cloudflare Pages
|
a6b5e54
to
de05a9b
Compare
de05a9b
to
8557845
Compare
layer: Layer | undefined | ||
network: Network | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these fields can be undefined. It would be caught by loaders. I think useScopeParam only needs to check that one of the useRouteLoaderData is found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that was also true previously, so was .valid
not needed, and always true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or do we never use the errors thrown in loaders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
large refactor in #1159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor looks cool, thanks! let's go with #1159 in this case and just sync changelog number there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I can see the plan is to merge this one first.
Consensus mockups don't match most of our ParaTimes views so we prob need to setup separated views. To discuss how we want to handle routes
here we can keep dynamic segments for ParaTimes and we will be able to add specific Consensus (static segment) routes
Will match backend design (consensus - runtimes separation) more. We keep current Paratimes as is.
W can rename some stuff like :layer to :runtime if we go with splats.possible routing options: