Skip to content

Commit

Permalink
Show block-level events in block details
Browse files Browse the repository at this point in the history
W.I.P. because filtering out tx-level events is done on the client
  • Loading branch information
csillag committed Nov 2, 2023
1 parent 939c891 commit caba9e7
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 0 deletions.
1 change: 1 addition & 0 deletions .changelog/990.feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Show block-level evens in block details
81 changes: 81 additions & 0 deletions src/app/pages/BlockDetailPage/EventsCard.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
import { FC, useState } from 'react'
import { useTranslation } from 'react-i18next'
import { ScrollingCard } from '../../components/PageLayout/ScrollingCard'
import CardHeader from '@mui/material/CardHeader'
import CardContent from '@mui/material/CardContent'

import { Layer, RuntimeEventType, useGetRuntimeEvents } from '../../../oasis-nexus/api'
import { ErrorBoundary } from '../../components/ErrorBoundary'
import { AppErrors } from '../../../types/errors'
import { SearchScope } from '../../../types/searchScope'
import { RuntimeEventsDetailedList } from '../../components/RuntimeEvents/RuntimeEventsDetailedList'
import { AddressSwitchOption } from '../../components/AddressSwitch'
import { EventFilterMode, EventFilterSwitch } from '../../components/RuntimeEvents/EventListFilterSwitch'
import { EmptyState } from '../../components/EmptyState'

export const eventsContainerId = 'events'

const EventsList: FC<{ scope: SearchScope; blockHeight: number; filterMode: EventFilterMode }> = ({
scope,
blockHeight,
filterMode,
}) => {
const { t } = useTranslation()
if (scope.layer === Layer.consensus) {
// Loading events for consensus blocks is not yet supported.
// Should use useGetConsensusEvents()
throw AppErrors.UnsupportedLayer
}
const eventsQuery = useGetRuntimeEvents(scope.network, scope.layer, {
block: blockHeight,
// TODO: search for tx_hase = null
})

const { isLoading, isError, data } = eventsQuery

const events = data?.data.events.filter(
event =>
!event.tx_hash && // TODO: remove filtering here if it's implemented using the query parameters
(filterMode === EventFilterMode.All || event.type !== RuntimeEventType.accountstransfer),
)

if (!events?.length && !isLoading) {
return (
<EmptyState
description={t('runtimeEvent.cantFindMatchingEvents')}
title={t('runtimeEvent.noEvents')}
light={true}
/>
)
}

return (
<RuntimeEventsDetailedList
scope={scope}
events={events}
isLoading={isLoading}
isError={isError}
addressSwitchOption={AddressSwitchOption.ETH}
/>
)
}

export const EventsCard: FC<{ scope: SearchScope; blockHeight: number }> = ({ scope, blockHeight }) => {
const [filterMode, setFilterMode] = useState<EventFilterMode>(EventFilterMode.All)
const { t } = useTranslation()
return (
<ScrollingCard id={eventsContainerId}>
<CardHeader
disableTypography
component="h3"
title={t('common.events')}
action={<EventFilterSwitch selected={filterMode} onSelectionChange={setFilterMode} />}
/>
<CardContent>
<ErrorBoundary light={true}>
<EventsList scope={scope} blockHeight={blockHeight} filterMode={filterMode} />
</ErrorBoundary>
</CardContent>
</ScrollingCard>
)
}
2 changes: 2 additions & 0 deletions src/app/pages/BlockDetailPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { BlockLink, BlockHashLink } from '../../components/Blocks/BlockLink'
import { RouteUtils } from '../../utils/route-utils'
import { useRequiredScopeParam } from '../../hooks/useScopeParam'
import { DashboardLink } from '../ParatimeDashboardPage/DashboardLink'
import { EventsCard } from './EventsCard'

export const BlockDetailPage: FC = () => {
const { t } = useTranslation()
Expand All @@ -43,6 +44,7 @@ export const BlockDetailPage: FC = () => {
<BlockDetailView isLoading={isLoading} block={block} />
</SubPageCard>
{!!block?.num_transactions && <TransactionsCard scope={scope} blockHeight={blockHeight} />}
<EventsCard scope={scope} blockHeight={blockHeight} />
</PageLayout>
)
}
Expand Down
2 changes: 2 additions & 0 deletions src/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@
},
"runtimeEvent": {
"cantLoadEvents": "Unfortunately we couldn't load the list of events. Please try again later.",
"noEvents": "No events",
"cantFindMatchingEvents": "We can't find any matching events.",
"accountsburn": "Tokens burnt",
"accountsmint": "Tokens minted",
"accountstransfer": "Transfer",
Expand Down

0 comments on commit caba9e7

Please sign in to comment.