Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline logicalLocation object in location #340

Closed
ghost opened this issue Mar 4, 2019 · 1 comment
Closed

Inline logicalLocation object in location #340

ghost opened this issue Mar 4, 2019 · 1 comment
Labels
design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-33 Issues to present at SARIF TC33

Comments

@ghost
Copy link

ghost commented Mar 4, 2019

Replace the properties location.fullyQualifiedLogicalName and location.logicalLocationIndex with location.logicalLocation of type logicalLocation. This allows you to inline the logical location information if you want, and it establishes a symmetry with location.physicalLocation.

@michaelcfanning FYI,
@michaelcfanning michaelcfanning added the tc-33 Issues to present at SARIF TC33 label Mar 7, 2019
ghost pushed a commit that referenced this issue Mar 9, 2019
Change draft for #340: inline logicalLocation object in location.
3df80ed
ghost pushed a commit that referenced this issue Mar 14, 2019
Merge changes for #340: location.logicalLocation,
942d5ef
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed and removed change-draft-available labels Mar 14, 2019
@ghost
Copy link
Author

ghost commented Mar 14, 2019

Draft was approved at TC #33.

@ghost ghost closed this as completed Mar 14, 2019
ghost pushed a commit that referenced this issue Mar 19, 2019
Provide "e-ballot #2" draft.
412c245 
This draft contains all the changes through "e-ballot #2," which
opened on Friday March 15 and will close on Friday March 22. It contains
changes for ballot issues #168, #291, #309, #320, #321, #326, #335,
and #341, as well as for previously approved issue #340.

It does _not_ contain changes for any issues from "e-ballot #3,"
which will open on Friday March 22 and close on Friday March 29.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-33 Issues to present at SARIF TC33
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning