Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invocation.attachments #327

Closed
ghost opened this issue Feb 20, 2019 · 3 comments
Closed

Remove invocation.attachments #327

ghost opened this issue Feb 20, 2019 · 3 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft e-ballot-3 impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-32

Comments

@ghost
Copy link

ghost commented Feb 20, 2019

The examples that the spec gives for invocation.attachments -- configuration files and plugins -- now have a better home in toolComponent.extensions. Is there any reason to keep invocation.attachments?
@ghost ghost added the tc-32 label Feb 20, 2019
@michaelcfanning
Copy link
Contributor

TC approves the change.

@ghost ghost added impact-breaks-producers 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. to-be-written design-approved The TC approved the design and I can write the change draft labels Feb 22, 2019
@ghost ghost self-assigned this Feb 22, 2019
@ghost ghost changed the title Consider removing invocation.attachments Remove invocation.attachments Feb 22, 2019
ghost pushed a commit that referenced this issue Feb 22, 2019
Change draft for #327, 'Remove invocation.attachments.'
a9f321d
@ghost ghost added the tc-33 Issues to present at SARIF TC33 label Mar 7, 2019
@michaelcfanning michaelcfanning removed the tc-33 Issues to present at SARIF TC33 label Mar 7, 2019
@ghost ghost added the e-ballot-3 label Mar 19, 2019
@ghost
Copy link
Author

ghost commented Mar 19, 2019

TODO: Merge this change draft into the provisional draft.

ghost pushed a commit that referenced this issue Mar 24, 2019
#327: Merge existing change draft into provisional draft.
06b521c
@ghost ghost added the merged Changes merged into provisional draft. label Mar 24, 2019
@ghost
Copy link
Author

ghost commented Apr 6, 2019

Approved in e-ballot-3.

@ghost ghost closed this as completed Apr 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft e-ballot-3 impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-32
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning