Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in ODF 1.4 WD-02 #53

Open
1 task
regina-henschel opened this issue Apr 1, 2024 · 10 comments
Open
1 task

Errors in ODF 1.4 WD-02 #53

regina-henschel opened this issue Apr 1, 2024 · 10 comments

Comments

@regina-henschel
Copy link
Contributor

  • 1.3 Terminology, Part 1. There is an "Error: Reference source not found" for the reference "nref-isoiec"
@regina-henschel
Copy link
Contributor Author

regina-henschel commented Apr 1, 2024

  • Appendix A, Part 3. There is a gray section "The table:tab-color attribute ...", which should not be there.
  • Appendix B, Part 3. There is a gray section "The table:tab-color attribute ...", which should not be there.

And same in other parts of the Appendix

@regina-henschel
Copy link
Contributor Author

  • Appendix C, Part 3. Table 26 is wider than the body text area.

@regina-henschel
Copy link
Contributor Author

Appendix G, Part 3. "Error:Reference source not found" for reference

  • "property-style:writing-mode-general"
  • "attribute-draw:decorative"
  • "attribute-text:condition-general"

@franciscave
Copy link
Contributor

  • 1.3 Terminology, Part 1. There is an "Error: Reference source not found" for the reference "nref-isoiec"

An entry for the ISO/IEC Directives was originally included in 1.4 Normative References. The Directives should not be referenced normatively, as they are not in themselves a standard. I suggest downgrading this paragraph to a Note and simply re-wording as follows:

Note: Within the normative text of this specification, the terms "shall", "shall not", "should", "should not", "may" and “need not” are to be interpreted as described in the ISO/IEC Directives, Part 2.

This is consistent with the form of words that are included in the Foreword of all ISO/IEC standards (and will in any case be added to the ISO/IEC edition of ODF 1.4):

International Standards are drafted in accordance with the rules given in the ISO/IEC Directives, Part 2.

@franciscave
Copy link
Contributor

franciscave commented Apr 4, 2024

  • Appendix A, Part 3. There is a gray section "The table:tab-color attribute ...", which should not be there.

    • Appendix B, Part 3. There is a gray section "The table:tab-color attribute ...", which should not be there.

And same in other parts of the Appendix

Bizarre! Either the XSLT scripts used for generating text from the schema are at fault, or there is a styling issue. I will investigate.

This appears to be as a result of a combination of the way that the XSLT scripts are determining where to put the generated text (preceding a heading styled 'Heading 1') and the way that 'Appendix Heading 1' is defined (based on 'Heading 1'). I'll fix the XSLT for the next run.

On further investigation, the generated text is already in the master change-tracked version, so is the result of an old error - and appears to have gone un-noticed in the published text of ODF 1.3!! Something to include in an Errata document?

Fixed in the master change-tracked version.

@franciscave
Copy link
Contributor

  • Appendix C, Part 3. Table 26 is wider than the body text area.

This appears to be true of a large proportion of tables. Do we really need to fix this?

I also note that the table identifiers in the LO Navigator pane bear no relation to the Table numbers in the document. Does this matter?

@franciscave
Copy link
Contributor

Appendix G, Part 3. "Error:Reference source not found" for reference

* [ ]  "property-style:writing-mode-general"

* [ ]  "attribute-draw:decorative"

* [ ]  "attribute-text:condition-general"

These have all been fixed in the master change-tracked version and also in the 'csd01' versions.

@franciscave
Copy link
Contributor

franciscave commented Apr 4, 2024

Appendix G, Part 3: Paragraph break missing between the two entries for text:start-value.

Fixed in the master change-tracked version.

franciscave added a commit that referenced this issue Apr 4, 2024
Fixing editorial issues reported in Github Issue #53 .
@franciscave
Copy link
Contributor

I have found broken cross-reference links in Part 4, and will fix those in the master tracked version.

franciscave added a commit that referenced this issue Apr 15, 2024
Fixed broken cross-reference links. See Github issue #53.
@franciscave
Copy link
Contributor

franciscave commented Apr 16, 2024

I have found various issues in Part 3:

  • Incorrect cross-reference to 20.442 tab:tab-color (probably caused by moving this property from chapter 19)
  • New properties draw:allow-overlap and draw:decorative not included in generated text, i.e. not listed under the elements that use these properties (probably a reference naming issue, but could be an issue with the XSLT for generating this text)
  • Incorrect styling of cross-references in 19.15.1.

These issues have been addressed in the latest commit of the master tracked version of Part 3.

franciscave added a commit that referenced this issue Apr 16, 2024
See Github issue #53: mostly fixing incorrect styling of cross-references. Also fixing the naming of references for properties in chapter 20 that have either been moved from chapter 19 or are new, and should be named with the prefix 'property-' to ensure correct processing of the schema to produce generated text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants