Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise type error for the unsupported object type #149

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Raise type error for the unsupported object type #149

merged 6 commits into from
Jul 13, 2021

Conversation

proneetsharma
Copy link
Collaborator

@oarriaga
Copy link
Owner

Thank you for the PR. Would it be possible to make so unit tests for your functionality?

@proneetsharma
Copy link
Collaborator Author

I have created the unit test for the added functionality. Please check.

@oarriaga
Copy link
Owner

Thank you for the PR can you refactor the tests to test the raise of exceptions in this manner:

paz/tests/paz/backend/opencv_image_test.py

Line 139 in 5f96305

with pytest.raises(Exception):

@oarriaga oarriaga merged commit 98282f2 into oarriaga:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proneetsharma @oarriaga