This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-173] fix incorrect result of q69 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
force-pushed
the
wip_fix_inplace
branch
2 times, most recently
from
e93b833
to
dcbfec0
Compare
|
|
|
|
rui-mo
force-pushed
the
wip_fix_inplace
branch
2 times, most recently
from
55e1408
to
6818181
Compare
|
|
|
|
|
|
zhouyuan
reviewed
Mar 22, 2021
| arrow::Status SliceBitmap(const std::shared_ptr<arrow::Buffer>& buffer, | ||
| std::shared_ptr<arrow::Buffer>* out) { | ||
| Range range(size * offset_, size * length_); | ||
| Range range(offset_, length_); |
There was a problem hiding this comment.
this seems like a big change, does this mean only q69 use sortinplace?
zhouyuan
approved these changes
Mar 22, 2021
|
verified locally, q69 is correct now |
|
verified TPC-DS on both partition/non-partition table |
zhouyuan
added a commit
that referenced
this pull request
Mar 29, 2021
* [NSE-130] support decimal round and abs (#166) * support decimal round and abs * remove duplicate cast in multiply/divide * [NSE-161] adding format check (#165) * adding format check Signed-off-by: Yuan Zhou <[email protected]> * formating code Signed-off-by: Yuan Zhou <[email protected]> * adding google format Signed-off-by: Yuan Zhou <[email protected]> * reformat with new style Signed-off-by: Yuan Zhou <[email protected]> * lower clang version to 10 Signed-off-by: Yuan Zhou <[email protected]> * adding script to format code Signed-off-by: Yuan Zhou <[email protected]> * [NSE-170]improve sort shuffle code (#171) * improve sort shuffle code Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * pass by ref in builder Signed-off-by: Yuan Zhou <[email protected]> * fix string/decimal builder Signed-off-by: Yuan Zhou <[email protected]> * [NSE-62]Fixing issue0062 for package arrow dependencies in jar with refresh2 (#172) * Add arrow build and dependency support * Add compress.sh default value * Fix bug for parameter's default value * Add CACHE PATH * fix copy bitmap in InplaceSort (#174) * [NSE-153] fix window results (#175) * fix window sort memory Signed-off-by: Yuan Zhou <[email protected]> * remove unused code Signed-off-by: Yuan Zhou <[email protected]> * fix windown w/o avg Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * fix decimal sort Signed-off-by: Yuan Zhou <[email protected]> * Fix issue 179 for arrow include directory (#181) * Fix issue0191 for .so file copy to tmp. (#192) * Following NSE-153, optimize fallback conditions for columnar window (#189) * Fix q14a/b segfault (#193) Signed-off-by: Chendi Xue <[email protected]> * [NSE-194]Turn on several Arrow parameters (#195) * Turn on several Arrow parameters * Change SIMD Level Setting * Hashmap build opt for semi/anti/exists join (#197) Signed-off-by: Chendi Xue <[email protected]> * [NSE-198] support the month() and dayofmonth() functions with DateType (#199) * [NSE-206] fix doc link, update limitations (#205) * fix doc link Signed-off-by: Yuan Zhou <[email protected]> * update arrow data source Signed-off-by: Yuan Zhou <[email protected]> * adding limitations Signed-off-by: Yuan Zhou <[email protected]> * mention limits Signed-off-by: Yuan Zhou <[email protected]> * [NSE-170] using unsafe appender (#203) This patch adds an unsafe appender which will reserve space before builder array. The boolean builder is not touched as only malloc small sized memory The string builder are not touched as it's diffcult to pre-allocate the space * using unsafe appender Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * update arrow branch Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rui Mo <[email protected]> Co-authored-by: Wei-Ting Chen <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: Chendi.Xue <[email protected]> Co-authored-by: JiaKe <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fixes the incorrect result of q69, occurring due to wrong offset and size when copying bitmap.
fixed #173.
#153
How was this patch tested?
q69 was verified, other queries are under testing