This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-1019] fix codegen for all expressions #1039
Merged
+338
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
It looks ColumnarFromUnixTime also has a similar issue. |
let me see if we could mark the default codegen support as false |
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_unixtimestamp
branch
from
24af8bc
to
5de484f
Compare
zhouyuan
changed the title
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_unixtimestamp
branch
from
976a0a2
to
41e530d
Compare
zhouyuan
changed the title
PHILO-HE
reviewed
Aug 8, 2022
| "get_json_object", | ||
| "translate", | ||
| "substr", | ||
| "instr", |
There was a problem hiding this comment.
It looks like instr should be replaced by locate here and in expression_codegen_visitor.cc. Please refer to the code in ColumnarStringInstr.
zhouyuan
commented
Aug 9, 2022
native-sql-engine/core/src/main/scala/com/intel/oap/expression/ColumnarExpression.scala
Show resolved
Hide resolved
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_unixtimestamp
branch
from
1580309
to
7f38a8e
Compare
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
PHILO-HE
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds
supportColumnarCodegenfor all functionsSigned-off-by: Yuan Zhou [email protected]
How was this patch tested?
pass jenkins