Allow upgrades on AWS and Azure using RHUI infrastructure #539

Rezney · 2020-07-28T12:37:36Z

- add actor to check for particular cloud package (provided from
special repository) to determine whether we are on public
cloud.

- disable DNF plugin with a message

- use the resolved mirrorlist on AWS

- copy RHUI data from special Leapp package when on
  public cloud and running without RHSM

- add hybrid (BIOS, UEFI) image grubby workaround

EDIT: requires PR #520

leapp-bot · 2020-07-28T12:38:33Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged.

If you want to re-run tests or request review, you can use following commands as a comment:

leapp-ci build to run unit tests and copr build
e2e tests to run unit tests, copr build and end-to-end tests (OAMG members only)
review please to notify leapp developers of review request

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py

repos/system_upgrade/el7toel8/actors/targetuserspacecreator/libraries/userspacegen.py

repos/system_upgrade/el7toel8/files/rhel_upgrade.py

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py

repos/system_upgrade/el7toel8/actors/dnfupgradetransaction/actor.py

repos/system_upgrade/el7toel8/models/dnfplugininfo.py

pirat89 · 2020-07-31T01:21:20Z

@Rezney the idea looks ok.

repos/system_upgrade/el7toel8/files/rhel_upgrade.py

zhukovgreen

@Rezney, please report also test coverage for new actors or heavily updated. In order to do this just run:
$ pytest {path to actor} --cov {path to actor}

repos/system_upgrade/el7toel8/actors/checkrhui/actor.py

repos/system_upgrade/el7toel8/actors/checkrhui/tests/component_test_checkrhui.py

repos/system_upgrade/el7toel8/actors/createresumeservice/actor.py

repos/system_upgrade/el7toel8/actors/dnfpackagedownload/actor.py

...tem_upgrade/el7toel8/actors/targetuserspacecreator/tests/unit_test_targetuserspacecreator.py

repos/system_upgrade/el7toel8/files/rhel_upgrade.py

AloisMahdal · 2020-08-22T11:57:32Z

@Rezney fails are because of stale branch. Please rebase. You can then run tests using e2e tests.

Rezney · 2020-08-24T10:28:50Z

@AloisMahdal thanks. Will e2e tests run everything we have?

Rezney · 2020-08-24T10:29:44Z

@examon the e2e test is failing cause we are not using RHEL7.9 image.

AloisMahdal · 2020-08-24T11:27:59Z

No, e2e tests runs a practical subset. Currently all integration tests and few upgrade sanity tests, rhel-7 x86_64 only (no rhel-alt).

Running "everything we have" is an effort that takes days (due to various reasons related to Beaker load and eg. stage CDN reliability) and is a substantial load on QE resources. If you want to extend beyond e2e tests I guess we could have a quick chat and figure out what would be the best mix.

AloisMahdal · 2020-08-24T17:28:34Z

The murphy-ci/upgrade fail is a false positive caused by recently deployed restraint-0.3.0 (leading to AVC). (Workaround applied in MORF/Murphy so next time it should be fine.)

pirat89

(First part; I am in the middle of PR now)

.pylintrc

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py

repos/system_upgrade/el7toel8/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py

repos/system_upgrade/el7toel8/actors/checktargetrepos/tests/test_checktargetrepos.py

repos/system_upgrade/el7toel8/actors/targetuserspacecreator/libraries/userspacegen.py

repos/system_upgrade/el7toel8/actors/kernelcmdlineconfig/actor.py

pirat89

Second part of the code review is finished.

repos/system_upgrade/el7toel8/actors/targetuserspacecreator/libraries/userspacegen.py

repos/system_upgrade/el7toel8/actors/updategrubcore/libraries/updategrubcore.py

repos/system_upgrade/el7toel8/files/rhel_upgrade.py

repos/system_upgrade/el7toel8/models/dnfplugintask.py

repos/system_upgrade/el7toel8/files/rhel_upgrade.py

RadekBiba · 2020-08-28T09:42:47Z

Upgrade from RHEL 7 to 8 passed in AWS using leapp-repository-0.11.0-0.202008261315Z.7ced225.rhui_all.PR539.el7 and Michal's playbook (with the necessary temporary workarounds).

Rezney · 2020-08-28T10:09:42Z

Upgrade from RHEL 7 to 8 passed in AWS using leapp-repository-0.11.0-0.202008261315Z.7ced225.rhui_all.PR539.el7 and Michal's playbook (with the necessary temporary workarounds).

Just for the transparency sakes, the 1st workaround was to not use localrepoinhibit actor as there is the recently reported BUG and a mass replace of $releasever to "8" in our leapp-rhui package as there is still missing the CDN symlink (SPMM-1688).

repos/system_upgrade/el7toel8/actors/addupgradebootentry/actor.py

repos/system_upgrade/el7toel8/actors/checktargetrepos/libraries/checktargetrepos.py

repos/system_upgrade/el7toel8/actors/kernelcmdlineconfig/actor.py

repos/system_upgrade/el7toel8/actors/updategrubcore/libraries/updategrubcore.py

pirat89 · 2020-08-28T12:05:00Z

LGTM. I will add approval later after merged PR #520. But it's good otherwise so far.

- add actor to check for particular cloud package (provided from special repository) to determine whether we are on public cloud. - disable DNF plugin with a message - use the resolved mirrorlist on AWS - copy RHUI data from special Leapp package when on public cloud and running without RHSM - add hybrid (BIOS, UEFI) image grubby workaround

Rezney · 2020-09-04T13:32:32Z

e2e tests

Rezney · 2020-09-07T13:18:48Z

e2e tests

Rezney · 2020-09-08T06:08:03Z

e2e tests

Rezney · 2020-09-09T08:21:41Z

Verified from RHUI team and in OAMG-3543.

Rezney added the WIP Work In Progress label Jul 28, 2020

This was referenced Jul 28, 2020

[DO NOT MERGE] - Upgrades on AWS POC #508

Closed

[WIP] - Add check RHUI actor #528

Closed

Rezney force-pushed the rhui_all branch 5 times, most recently from 7bc02a9 to 775aee1 Compare July 30, 2020 06:48

vinzenz reviewed Jul 30, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py Outdated Show resolved Hide resolved

vinzenz reviewed Jul 30, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/targetuserspacecreator/libraries/userspacegen.py Show resolved Hide resolved

vinzenz reviewed Jul 30, 2020

View reviewed changes

repos/system_upgrade/el7toel8/files/rhel_upgrade.py Outdated Show resolved Hide resolved

vinzenz reviewed Jul 30, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py Outdated Show resolved Hide resolved

Rezney force-pushed the rhui_all branch 4 times, most recently from 4e0dafb to 3d0e42c Compare July 30, 2020 14:21

pirat89 reviewed Jul 31, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py Outdated Show resolved Hide resolved

pirat89 reviewed Jul 31, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/addupgradebootentry/libraries/addupgradebootentry.py Outdated Show resolved Hide resolved

pirat89 reviewed Jul 31, 2020

View reviewed changes

repos/system_upgrade/el7toel8/actors/dnfupgradetransaction/actor.py Outdated Show resolved Hide resolved

pirat89 requested changes Jul 31, 2020

View reviewed changes

repos/system_upgrade/el7toel8/models/dnfplugininfo.py Outdated Show resolved Hide resolved

Rezney force-pushed the rhui_all branch from 3d0e42c to 7201174 Compare July 31, 2020 06:56

Rezney commented Jul 31, 2020

View reviewed changes

repos/system_upgrade/el7toel8/files/rhel_upgrade.py Outdated Show resolved Hide resolved

zhukovgreen reviewed Jul 31, 2020

View reviewed changes

Rezney force-pushed the rhui_all branch 5 times, most recently from d6e2a88 to 7a6d87a Compare July 31, 2020 16:38

Rezney force-pushed the rhui_all branch 4 times, most recently from 5cdb17d to 822a827 Compare August 24, 2020 09:47

pirat89 requested changes Aug 25, 2020

View reviewed changes

Rezney force-pushed the rhui_all branch 4 times, most recently from 7ced225 to e32ab33 Compare August 27, 2020 08:24

pirat89 requested changes Aug 28, 2020

View reviewed changes

Rezney force-pushed the rhui_all branch 2 times, most recently from 290c333 to 81b53a0 Compare August 28, 2020 11:56

Rezney force-pushed the rhui_all branch from 81b53a0 to 6c4f2d7 Compare September 4, 2020 11:23

pirat89 approved these changes Sep 4, 2020

View reviewed changes

pirat89 changed the title ~~[DoNotMerge] - Allow upgrades on AWS and Azure using RHUI infrastructure~~ Allow upgrades on AWS and Azure using RHUI infrastructure Sep 9, 2020

pirat89 merged commit 2e13c88 into oamg:master Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow upgrades on AWS and Azure using RHUI infrastructure #539

Allow upgrades on AWS and Azure using RHUI infrastructure #539

Rezney commented Jul 28, 2020 •

edited by pirat89

Loading

leapp-bot commented Jul 28, 2020

pirat89 commented Jul 31, 2020

zhukovgreen left a comment

AloisMahdal commented Aug 22, 2020

Rezney commented Aug 24, 2020

Rezney commented Aug 24, 2020

AloisMahdal commented Aug 24, 2020

AloisMahdal commented Aug 24, 2020

pirat89 left a comment

pirat89 left a comment

RadekBiba commented Aug 28, 2020

Rezney commented Aug 28, 2020

pirat89 commented Aug 28, 2020

Rezney commented Sep 4, 2020

Rezney commented Sep 7, 2020

Rezney commented Sep 8, 2020

Rezney commented Sep 9, 2020

Allow upgrades on AWS and Azure using RHUI infrastructure #539

Allow upgrades on AWS and Azure using RHUI infrastructure #539

Conversation

Rezney commented Jul 28, 2020 • edited by pirat89 Loading

leapp-bot commented Jul 28, 2020

Thank you for contributing to the Leapp project!

pirat89 commented Jul 31, 2020

zhukovgreen left a comment

Choose a reason for hiding this comment

AloisMahdal commented Aug 22, 2020

Rezney commented Aug 24, 2020

Rezney commented Aug 24, 2020

AloisMahdal commented Aug 24, 2020

AloisMahdal commented Aug 24, 2020

pirat89 left a comment

Choose a reason for hiding this comment

pirat89 left a comment

Choose a reason for hiding this comment

RadekBiba commented Aug 28, 2020

Rezney commented Aug 28, 2020

pirat89 commented Aug 28, 2020

Rezney commented Sep 4, 2020

Rezney commented Sep 7, 2020

Rezney commented Sep 8, 2020

Rezney commented Sep 9, 2020

Rezney commented Jul 28, 2020 •

edited by pirat89

Loading