[RHELC-1393] Move logger initialization to initialize module #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
added
kind/bug-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 94.89% 94.90%
=======================================
Files 49 49
Lines 4549 4550 +1
Branches 809 809
=======================================
+ Hits 4317 4318 +1
Misses 156 156
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Venefilyn
reviewed
Feb 12, 2024
Initializing the logger module earlier makes the tool work correctly when trying to find the /etc/system-release file, and if it is not there, throw a critical error to the user before anything else happens. If we don't move the module to this point, the first /etc/system-releaes check will silently fail and only the next call will throw the exception, because at this point, we already have the logger initialized. To prevent further executions in the system, it is more reliable to initialize the logger module earlier. Signed-off-by: Rodolfo Olivieri <[email protected]>
Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
force-pushed
the
traceback-in-missing-file
branch
from
c4b1530 to
e8d4af8
Compare
|
/packit test --labels tier0 |
pr-watson
approved these changes
Feb 20, 2024
8 tasks
|
Only 1 test failing unrelated to code, merging |
This was referenced Feb 21, 2024
Merged
jochapma
pushed a commit
to jochapma/convert2rhel
that referenced
this pull request
Mar 11, 2024
* Move logger initialization to initialize module Initializing the logger module earlier makes the tool work correctly when trying to find the /etc/system-release file, and if it is not there, throw a critical error to the user before anything else happens. If we don't move the module to this point, the first /etc/system-releaes check will silently fail and only the next call will throw the exception, because at this point, we already have the logger initialized. To prevent further executions in the system, it is more reliable to initialize the logger module earlier. Signed-off-by: Rodolfo Olivieri <[email protected]> * Revert initialize_file_logger function Signed-off-by: Rodolfo Olivieri <[email protected]> --------- Signed-off-by: Rodolfo Olivieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the logger module earlier makes the tool work correctly when trying to find the /etc/system-release file, and if it is not there, throw a critical error to the user before anything else happens.
If we don't move the module to this point, the first /etc/system-releaes check will silently fail and only the next call will throw the exception, because at this point, we already have the logger initialized.
To prevent further executions in the system, it is more reliable to initialize the logger module earlier.
Jira Issues: RHELC-1393
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant