Make "mobile" false when "tablet" is true #122
Conversation
|
Looks good to me. @dougwilson thoughts on this? |
|
Essentially I agree that it should probably be consistent, as in mobile should either always be true when tablet is true or always false when table is false. But even then, a lot of this is shrouded in history, where things like phones would be just called "mobile", and there was not really need for a distinction between phone and tablet. Now with tablet and phone classifications, it seems to bring up the question of "what does mobile mean?". If we want to just keep it simple, I think this pull request does that. |
|
My preferred answer for, "what does mobile mean?" in this context is, "a device with screen and input characteristics such that the mobile version of a site is generally preferred." That's more or less the logic put forth in that article attached to issue #38, and we correspondingly apply that logic to Android tablets, just not other tablets. |
Make "mobile" false when "tablet" is true
|
I saw the bump to version 3.0, which makes sense to me. I have a few other changes ready to go, and if we're bumping the major version I think it'd be a good time for me to finish up the work on robot_version() (which is currently 90% done, as in "now I only have the other 90% left to do"). That's also going to be a breaking change for some cases and I feel like it'd be good to get them both into the same major version bump if we can. Sound good? |
|
If you have more patches, that's great! I already did release 3.0 last night, but I'm fine with bumping to 4.0 with other breaking changes. Numbers are cheap. ;) |
I have a proposed solution to issue #90 -- make "mobile" indicate true when the mobile version of a page is preferable, and false otherwise. This involves a significant change, of course, making "mobile" false on tablet devices, when it's generally (but not always) true right now. I feel like this is a consistent and correct way to behave, though; it's consistent and simple to understand when people think about the tablet case, and generally gives correct behavior when people don't think about the tablet case. The behavior we have now breaks in the common case where the user of HTTP::BrowserDetect doesn't think about tablets (they wind up giving the mobile version of the page to tablet users, which in most cases is undesired).