fix: OakModal blowing up when doing SSR
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`document.body` isn't available during SSR, so this would blow up. This commit adds a awful `useEffect` which flips an `isMounted` boolean which we can use to determine if we're rendering on the client while avoiding a server->client markup mismatch warning. *groan*
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carlmw
commented
Jun 18, 2024
carlmw
commented
Jun 18, 2024
carlmw
commented
Jun 18, 2024
simonrose121
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
LGTM!
This is pretty how much Next's example handles the same issue: https://github.com/vercel/next.js/tree/canary/examples/with-portals
that's where my Googling led me too 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.bodyisn't available during SSR, so this would blow up.This commit adds an awful
useEffectwhich flips anisMountedboolean which we can use to determine if we're rendering on the client while avoiding a server->client markup mismatch warning. groanHow to review this PR
https://deploy-preview-202--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakmodal--docs
Testing instructions
This should behave as before in Storybook where the modal is always rendered client-side. The only way to test this fix is to use it with SSR (which i've done in OWA to verify).