Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve chances of showing 5 relevant plans #444

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: improve chances of showing 5 relevant plans #444

merged 1 commit into from
Dec 12, 2024

Conversation

mantagen
Copy link
Collaborator

Description

  • currently in the prompt example response, we provide only 3 relevant lesson titles. Likely this confuses matters, and will lead to us sometimes only showing the user 3 lessons.
  • this PR adds a 4th and 5th title, making it more likely that the user will be presented with all 5 lessons.

@mantagen mantagen requested a review from a team December 11, 2024 15:16
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:20pm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Playwright test results

passed  14 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 35 seconds
commit  7581412

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@mantagen mantagen merged commit 4955a1e into main Dec 12, 2024
18 checks passed
@mantagen mantagen deleted the fix/always-5-relevant-plans branch December 12, 2024 10:18
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikeritson-oak mikeritson-oak mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantagen @oak-machine-user @codeincontext