Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managedvolume: add support for local device #387

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

WanzenBug
Copy link
Contributor

"local" connections are used by storage systems that directly set up devices on vdsm nodes, such as linstor1

"local" connections are used by storage systems that directly set up devices
on vdsm nodes, such as linstor[1]

[1]: https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/linstor-driver.html

Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
@aesteve-rh
Copy link
Member

Thanks for the contribution!

Could you please briefly describe how did you test the update?

@aesteve-rh
Copy link
Member

/ost

@WanzenBug
Copy link
Contributor Author

Could you please briefly describe how did you test the update?

I used a local oVirt setup (Version 4.5.4), consisting of 4 nodes. I enabled the Managed Block Storage preview, and completed the necessary set up for using linstor, which runs a storage agent on every node. The driver can use either iSCSI transport, or it creates a DRBD device directly on the node, for which it then uses the local connection driver.

Then, after making some changes (the one you see here to vdsm, and some changes to the linstor driver):

  • I created a volume
  • I attached it to a VM
  • I verified (using virsh dumpxml) that the volume attached is actually using the expected device
  • Migrated the VM to another host
  • Stopped and started the VM
  • Created a snapshot

@aesteve-rh
Copy link
Member

/ost

1 similar comment
@aesteve-rh
Copy link
Member

/ost

@aesteve-rh aesteve-rh merged commit 447b8e2 into oVirt:master Apr 5, 2023
@aesteve-rh
Copy link
Member

Thanks again for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants